Commit Diff

Commit:
8d07ef48ecf42b004c38bb48b0eec3eb5cd06a30
From:
Stefan Sperling <stsp@stsp.name>
Date:
Message:
remove closefrom() in gotd when gotsys is run closefrom doesn't have the desired effect as it may affect unrelated open files in the parent process. The right way to deal with this seems to be setting the close-on-exec flag on file descriptors instead.
Actions:
Patch | Tree
commit - 52b119c266230d82148c26d259a94c5c424c58b3
commit + 8d07ef48ecf42b004c38bb48b0eec3eb5cd06a30
blob - 8030e1d9e78ad1e744a42dc5e10d6fea257b3acb
blob + 653f7c37ce16b3b4b5fd14142b0ebdc015074d76
--- gotd/gotd.c
+++ gotd/gotd.c
@@ -1939,8 +1939,6 @@ run_gotsys_check(struct gotd_client *client, struct go
 			fatal("cannot redirect stderr");
 	} else if (fcntl(proc->pipe[1], F_SETFD, 0) == -1)
 		fatal("cannot fcntl stderr");
-
-	closefrom(STDERR_FILENO + 1);
 
 	argv[argc++] = GOTD_PATH_PROG_GOTSYS;
 	argv[argc++] = "check";
@@ -1990,8 +1988,6 @@ run_gotsys_apply(struct gotd_repo *repo)
 		log_debug("running gotsys apply (PID %d)", pid);
 		return;
 	}
-
-	closefrom(STDERR_FILENO + 1);
 
 	argv[argc++] = GOTD_PATH_PROG_GOTSYS;
 	argv[argc++] = "apply";