Commit Diff
- Commit:
cc79381d1af8e783b6164745018a174399f46004
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
- Message:
- NUL-terminate empty logmsg buffer for strlcat(3) Because the logmsg output buffer was not NUL-terminated after allocation, strlcat(3) could append log message contents copied from the temporary file at a wrong memory location. In the case observed by me, this bug resulted in a broken commit object.
- Actions:
- Patch | Tree
--- got/got.c +++ got/got.c @@ -2381,6 +2381,7 @@ collect_commit_logmsg(struct got_pathlist_head *commit err = got_error_from_errno("malloc"); goto done; } + (*logmsg)[0] = '\0'; len = 0; fp = fopen(a->logmsg_path, "r");