commit 17c93e37adaf6ec18654a4d9cea0846a0d5394f3
from: Florian Obser <florian@narrans.de>
via: Thomas Adam <thomas@xteddy.org>
date: Thu Jul 21 08:32:00 2022 UTC

Do not ignore error from got_pathlist_append.

Found by llvm's scan-build (dead store).
OK stsp

commit - ef944b8b4a94171b8635afaf4a8354d652f841cd
commit + 17c93e37adaf6ec18654a4d9cea0846a0d5394f3
blob - 5bbac0a0724746a2b3f761ee079860fd541142cb
blob + 980664a3d3b0e347aabd00ccd1f7e38929ce7498
--- libexec/got-send-pack/got-send-pack.c
+++ libexec/got-send-pack/got-send-pack.c
@@ -387,6 +387,9 @@ send_pack(int fd, struct got_pathlist_head *refs,
 			goto done;
 
 		err = got_pathlist_append(&their_refs, refname, id);
+		if (err)
+			goto done;
+
 		if (chattygot)
 			fprintf(stderr, "%s: remote has %s %s\n",
 			    getprogname(), refname, id_str);