commit 4231e6b557d72b2ae13ede2aecdd6391f271f25e
from: Stefan Sperling <stsp@stsp.name>
via: Thomas Adam <thomas@xteddy.org>
date: Sun Oct 30 17:15:57 2022 UTC

got-fetch-pack: fix wrong memmove length leading to dubious checksum failures

ok millert tracey

commit - 92ddd9f6696006cebffafa1258f4ba366e411302
commit + 4231e6b557d72b2ae13ede2aecdd6391f271f25e
blob - 58bc7d00a21178c003a4b9107128d91885e349f1
blob + 79f6e3091c9517ab7d3915a6f020ce41a11e0660
--- libexec/got-fetch-pack/got-fetch-pack.c
+++ libexec/got-fetch-pack/got-fetch-pack.c
@@ -688,7 +688,8 @@ fetch_pack(int fd, int packfd, uint8_t *pack_sha1,
 				while (sha1_buf_len > 0 &&
 				    sha1_buf_len + r > SHA1_DIGEST_LENGTH) {
 					SHA1Update(&sha1_ctx, sha1_buf, 1);
-					memmove(sha1_buf, sha1_buf + 1, 1);
+					memmove(sha1_buf, sha1_buf + 1,
+					    sha1_buf_len - 1);
 					sha1_buf_len--;
 				}