commit 5662d61df841f27dd548625738d05c59ee54c2a4 from: Josh Rickmar date: Mon Jul 03 19:29:56 2023 UTC Make got_worktree_get_base_ref_name static Nothing appears to benefit from this being non-static, and it was missing from the public API headers as well. ok stsp@ commit - d556241a037d31a830ef830c6cb301419bb84087 commit + 5662d61df841f27dd548625738d05c59ee54c2a4 blob - a35884552cf66d678f0db623e1dd92d976a7014e blob + fefcc854456ad7fdcd7841dda7f3095162a212e6 --- lib/got_lib_worktree.h +++ lib/got_lib_worktree.h @@ -73,9 +73,6 @@ struct got_commitable { #define GOT_WORKTREE_BASE_REF_PREFIX "refs/got/worktree/base" -const struct got_error *got_worktree_get_base_ref_name(char **, - struct got_worktree *worktree); - /* Temporary branch which accumulates commits during a rebase operation. */ #define GOT_WORKTREE_REBASE_TMP_REF_PREFIX "refs/got/worktree/rebase/tmp" blob - 39490809ede903773452d7a6331a5a959b7b756a blob + 20e319355137e3ec594f1a28760412c19ab58905 --- lib/worktree.c +++ lib/worktree.c @@ -2350,8 +2350,8 @@ got_worktree_get_logmsg_ref_name(char **refname, struc return get_ref_name(refname, worktree, prefix); } -const struct got_error * -got_worktree_get_base_ref_name(char **refname, struct got_worktree *worktree) +static const struct got_error * +get_base_ref_name(char **refname, struct got_worktree *worktree) { return get_ref_name(refname, worktree, GOT_WORKTREE_BASE_REF_PREFIX); } @@ -2448,7 +2448,7 @@ ref_base_commit(struct got_worktree *worktree, struct struct got_reference *ref = NULL; char *refname; - err = got_worktree_get_base_ref_name(&refname, worktree); + err = get_base_ref_name(&refname, worktree); if (err) return err;