commit 5d79cba5f44776394c0437df6fee96a5eb2e34df from: Stefan Sperling date: Mon Jan 28 22:09:27 2019 UTC eliminate redundant strlen() call in cmp_entries() commit - 6e8d14a311bea47a636572f210decdc00d6fb1ea commit + 5d79cba5f44776394c0437df6fee96a5eb2e34df blob - 2665f6ff9da45c201ba781995e3823447cb6dfc9 blob + 60e6716c7c18c43357950acbac0fa9eff47dd59f --- lib/fileindex.c +++ lib/fileindex.c @@ -569,11 +569,9 @@ in_same_subdir(struct got_fileindex_entry *ie, const c */ static int cmp_entries(struct got_fileindex_entry *ie, const char *parent_path, - struct got_tree_entry *te) + size_t parent_len, struct got_tree_entry *te) { - size_t parent_len = strlen(parent_path); int cmp = strncmp(ie->path, parent_path, parent_len); - if (cmp == 0 || in_same_subdir(ie, parent_path)) { char *ie_name = ie->path + parent_len; while (ie_name[0] == '/') @@ -653,7 +651,7 @@ diff_fileindex_tree(struct got_fileindex *fileindex, te = SIMPLEQ_FIRST(&entries->head); do { if (te && *ie) { - int cmp = cmp_entries(*ie, path, te); + int cmp = cmp_entries(*ie, path, path_len, te); if (cmp == 0) { err = cb->diff_old_new(cb_arg, *ie, te, path);