commit 705e365cc30a9ee94c203029b7020c7c55bc74b8 from: Mark Jamsek via: Thomas Adam date: Fri Jan 10 22:29:14 2025 UTC use got_object_id_queue_free() instead of hand-rolled code ok stsp@ commit - 5eecb14c8e822a70dc333f986dd59e7a0d17ee7c commit + 705e365cc30a9ee94c203029b7020c7c55bc74b8 blob - 87aaa4df225395cacaa2b419da135082e2ddc6a5 blob + 62e8ce84a8f3f57a254769736df681b070e28264 --- cvg/cvg.c +++ cvg/cvg.c @@ -3911,11 +3911,7 @@ print_commits(struct got_object_id *root_id, struct go } } done: - while (!STAILQ_EMPTY(&reversed_commits)) { - qid = STAILQ_FIRST(&reversed_commits); - STAILQ_REMOVE_HEAD(&reversed_commits, entry); - got_object_qid_free(qid); - } + got_object_id_queue_free(&reversed_commits); got_pathlist_free(&changed_paths, GOT_PATHLIST_FREE_ALL); if (search_pattern) regfree(®ex); blob - 3b2f34e5d0f01f0775d3e170b411524defd0af0d blob + 1adc19bce55e8b370f6ee5282da860abe3112194 --- got/got.c +++ got/got.c @@ -4689,11 +4689,7 @@ print_commits(struct got_object_id *root_id, struct go } } done: - while (!STAILQ_EMPTY(&reversed_commits)) { - qid = STAILQ_FIRST(&reversed_commits); - STAILQ_REMOVE_HEAD(&reversed_commits, entry); - got_object_qid_free(qid); - } + got_object_id_queue_free(&reversed_commits); got_pathlist_free(&changed_paths, GOT_PATHLIST_FREE_ALL); if (search_pattern) regfree(®ex); blob - 50c0f8408c2cdb65e1f0a442c26f9f38c1be1cb1 blob + 2f1b2189449fcc425f84391d4ebdc1e96ae22e0a --- gotd/repo_write.c +++ gotd/repo_write.c @@ -1953,11 +1953,7 @@ print_commits(struct got_object_id *root_id, struct go done: if (commit) got_object_commit_close(commit); - while (!STAILQ_EMPTY(&reversed_commits)) { - qid = STAILQ_FIRST(&reversed_commits); - STAILQ_REMOVE_HEAD(&reversed_commits, entry); - got_object_qid_free(qid); - } + got_object_id_queue_free(&reversed_commits); got_pathlist_free(&changed_paths, GOT_PATHLIST_FREE_ALL); got_commit_graph_close(graph); return err; blob - 3b225f2aa9fdc2ff9236830c2f59dc04580bcec0 blob + a5a632533613cb01b96fee51cdd4d7033964b7e2 --- tog/tog.c +++ tog/tog.c @@ -8382,12 +8382,7 @@ close_blame_view(struct tog_view *view) if (s->blame.thread) err = stop_blame(&s->blame); - while (!STAILQ_EMPTY(&s->blamed_commits)) { - struct got_object_qid *blamed_commit; - blamed_commit = STAILQ_FIRST(&s->blamed_commits); - STAILQ_REMOVE_HEAD(&s->blamed_commits, entry); - got_object_qid_free(blamed_commit); - } + got_object_id_queue_free(&s->blamed_commits); if (using_mock_io) { struct tog_blame_thread_args *bta = &s->blame.thread_args;