commit 9e26f05792286fa1ff16e43516f1f4a688b672b9
from: Omar Polo <op@omarpolo.com>
via: Thomas Adam <thomas@xteddy.org>
date: Thu Jun 22 13:10:34 2023 UTC

avoid strlen in for(;;)

ok jamsek, stsp

commit - 8050095e3acba3100327de8abb9a427cb547089b
commit + 9e26f05792286fa1ff16e43516f1f4a688b672b9
blob - c03351b201e51e2910ab2d97e0486faf2b0fe56c
blob + f450103ce056eeb7549745d5e9be8faf481f5f20
--- got/got.c
+++ got/got.c
@@ -5968,7 +5968,7 @@ print_entry(struct got_tree_entry *te, const char *id,
 		err = got_tree_entry_get_symlink_target(&link_target, te, repo);
 		if (err)
 			return err;
-		for (i = 0; i < strlen(link_target); i++) {
+		for (i = 0; link_target[i] != '\0'; i++) {
 			if (!isprint((unsigned char)link_target[i]))
 				link_target[i] = '?';
 		}
@@ -6325,7 +6325,7 @@ cmd_status(int argc, char *argv[])
 			st.suppress = 1;
 			/* fallthrough */
 		case 's':
-			for (i = 0; i < strlen(optarg); i++) {
+			for (i = 0; optarg[i] != '\0'; i++) {
 				switch (optarg[i]) {
 				case GOT_STATUS_MODIFY:
 				case GOT_STATUS_ADD:
@@ -7988,7 +7988,7 @@ cmd_remove(int argc, char *argv[])
 			can_recurse = 1;
 			break;
 		case 's':
-			for (i = 0; i < strlen(optarg); i++) {
+			for (i = 0; optarg[i] != '\0'; i++) {
 				switch (optarg[i]) {
 				case GOT_STATUS_MODIFY:
 					delete_local_mods = 1;
blob - 31f1f3d7c931e5646bc74db0a358823c32e38196
blob + 11c1fd527fef5bf80e8306b010d4ab0c2feeb3c6
--- tog/tog.c
+++ tog/tog.c
@@ -7308,7 +7308,7 @@ draw_tree_entries(struct tog_view *view, const char *p
 				free(id_str);
 				return err;
 			}
-			for (i = 0; i < strlen(link_target); i++) {
+			for (i = 0; i < link_target[i] != '\0'; i++) {
 				if (!isprint((unsigned char)link_target[i]))
 					link_target[i] = '?';
 			}