commit 9e39ca77238c1ce717f8ccb3c0ffc8e229cd1850
from: Florian Obser <florian@narrans.de>
via: Thomas Adam <thomas@xteddy.org>
date: Thu Jul 21 08:32:00 2022 UTC

path_got is unused and never assigned, no need to free it
OK stsp

commit - 3521b46649a4794366372744129e4e9d171d344f
commit + 9e39ca77238c1ce717f8ccb3c0ffc8e229cd1850
blob - 8c7f34dc5546c4b6cd6a552c84a85544a9b2c00a
blob + 6efb1b06ff7d7a6f0d2b9add9dead5af05ec06c5
--- lib/worktree.c
+++ lib/worktree.c
@@ -1254,13 +1254,12 @@ install_symlink(int *is_bad_symlink, struct got_worktr
 	const struct got_error *err = NULL;
 	char target_path[PATH_MAX];
 	size_t len, target_len = 0;
-	char *path_got = NULL;
 	const uint8_t *buf = got_object_blob_get_read_buf(blob);
 	size_t hdrlen = got_object_blob_get_hdrlen(blob);
 
 	*is_bad_symlink = 0;
 
-	/* 
+	/*
 	 * Blob object content specifies the target path of the link.
 	 * If a symbolic link cannot be installed we instead create
 	 * a regular file which contains the link target path stored
@@ -1303,7 +1302,7 @@ install_symlink(int *is_bad_symlink, struct got_worktr
 		    GOT_DEFAULT_FILE_MODE, GOT_DEFAULT_FILE_MODE, blob,
 		    restoring_missing_file, reverting_versioned_file, 1,
 		    path_is_unversioned, repo, progress_cb, progress_arg);
-		goto done;
+		return err;
 	}
 
 	if (symlink(target_path, ondisk_path) == -1) {
@@ -1312,12 +1311,12 @@ install_symlink(int *is_bad_symlink, struct got_worktr
 			if (path_is_unversioned) {
 				err = (*progress_cb)(progress_arg,
 				    GOT_STATUS_UNVERSIONED, path);
-				goto done;
+				return err;
 			}
 			err = replace_existing_symlink(&symlink_replaced,
 			    ondisk_path, target_path, target_len);
 			if (err)
-				goto done;
+				return err;
 			if (progress_cb) {
 				if (symlink_replaced) {
 					err = (*progress_cb)(progress_arg,
@@ -1329,25 +1328,25 @@ install_symlink(int *is_bad_symlink, struct got_worktr
 					    GOT_STATUS_EXISTS, path);
 				}
 			}
-			goto done; /* Nothing else to do. */
+			return err; /* Nothing else to do. */
 		}
 
 		if (errno == ENOENT) {
 			char *parent;
 			err = got_path_dirname(&parent, ondisk_path);
 			if (err)
-				goto done;
+				return err;
 			err = add_dir_on_disk(worktree, parent);
 			free(parent);
 			if (err)
-				goto done;
+				return err;
 			/*
 			 * Retry, and fall through to error handling
 			 * below if this second attempt fails.
 			 */
 			if (symlink(target_path, ondisk_path) != -1) {
 				err = NULL; /* success */
-				goto done;
+				return err;
 			}
 		}
 
@@ -1371,8 +1370,6 @@ install_symlink(int *is_bad_symlink, struct got_worktr
 	} else if (progress_cb)
 		err = (*progress_cb)(progress_arg, reverting_versioned_file ?
 		    GOT_STATUS_REVERT : GOT_STATUS_ADD, path);
-done:
-	free(path_got);
 	return err;
 }