commit bafea5babab6072bfa7528ad7c767bde76a446a3
from: Josh Rickmar <jrick@zettaport.com>
date: Fri Jul 07 07:01:49 2023 UTC

plug a leak in insert_sendable_ref error path

from op@

commit - 27555e8e6053ab0cc846d201757b588d5a79293f
commit + bafea5babab6072bfa7528ad7c767bde76a446a3
blob - bfb0e6f7f0b590d525fca551e9d76d8d7d6abd04
blob + 34f52864427db4b589d98608c5c77042da5d361b
--- lib/send.c
+++ lib/send.c
@@ -180,11 +180,10 @@ insert_sendable_ref(struct got_pathlist_head *refs, co
 
 	err = got_pathlist_insert(NULL, refs, refname, id);
 done:
-	if (err != NULL) {
-		if (ref)
-			got_ref_close(ref);
+	if (ref)
+		got_ref_close(ref);
+	if (err)
 		free(id);
-	}
 	return err;
 }
 
@@ -441,7 +440,7 @@ got_send_pack(const char *remote_name, struct got_path
 	}
 
 	/*
-	 * Also prepare the array of our object IDs which
+	 * Prepare the array of our object IDs which
 	 * will be needed for generating a pack file.
 	 */
 	TAILQ_FOREACH(pe, &have_refs, entry) {