commit bb958056527fca453ea20b8f92f2cb03dd41a45b
from: Stefan Sperling <stsp@stsp.name>
via: Thomas Adam <thomas@xteddy.org>
date: Wed Feb 05 12:44:19 2025 UTC

avoid needless use of STAILQ_FOREACH_SAFE, we are not removing elements here

commit - c1f3b0bfad7a8052e11c77552c4b095a1515020c
commit + bb958056527fca453ea20b8f92f2cb03dd41a45b
blob - 7e52756f9211c011c9f5681c3893d02cab59d394
blob + cbad2d8749f2b8323cb007760f078e4d316c7568
--- libexec/got-read-pack/got-read-pack.c
+++ libexec/got-read-pack/got-read-pack.c
@@ -1698,7 +1698,7 @@ repaint_parent_commits(struct got_object_id *commit_id
 		return err;
 
 	while (commit) {
-		struct got_object_qid *pid, *qid, *tmp;
+		struct got_object_qid *pid, *qid;
 		int idx;
 
 		parents = got_object_commit_get_parent_ids(commit);
@@ -1762,7 +1762,7 @@ repaint_parent_commits(struct got_object_id *commit_id
 		 * In case this commit is on the caller's list of
 		 * pending commits to traverse, repaint it there.
 		 */
-		STAILQ_FOREACH_SAFE(qid, ids, entry, tmp) {
+		STAILQ_FOREACH(qid, ids, entry) {
 			if (got_object_id_cmp(&qid->id, &pid->id) != 0)
 				continue;
 			err = paint_commit(qid, color);