commit c02f62d5c95274029a4a00e1aa97ef0d3f9bbeec
from: Stefan Sperling <stsp@stsp.name>
via: Thomas Adam <thomas@xteddy.org>
date: Mon Apr 29 12:22:32 2024 UTC

fix an fd leak in gotd's notify process

This leak resulted in the gotd notify process spinning on CPU in
an imsg_read() -> EAGAIN loop once it ran out of file descriptors.

commit - 2671aa26ceb0757e1fb1cc55b6d0571b592f5483
commit + c02f62d5c95274029a4a00e1aa97ef0d3f9bbeec
blob - f768c694591c53af7e3f81679d3e48d236dec701
blob + 1c7df38d54eae629cb515f41861efe1173fd9c2c
--- gotd/notify.c
+++ gotd/notify.c
@@ -116,6 +116,7 @@ remove_session(struct gotd_notify_session *session)
 	slot = session_hash(session->id) % nitems(gotd_notify_sessions);
 	STAILQ_REMOVE(&gotd_notify_sessions[slot], session,
 	    gotd_notify_session, entry);
+	close(session->iev.ibuf.fd);
 	free(session);
 }