commit c0ce8a2bcad97c245acf33698ddcc903a46fce22 from: Mark Jamsek via: Thomas Adam date: Sat Jan 14 16:45:29 2023 UTC catch a few missed got_pathlist_append() error checks ok stsp@ commit - 1a0805676b811f75437d3194775020a0341ace96 commit + c0ce8a2bcad97c245acf33698ddcc903a46fce22 blob - e7f9752fa3321b4f2a730099f559505a4d4a5a93 blob + a4382294495a647321fccc2881af4c226294b2a5 --- got/got.c +++ got/got.c @@ -2483,14 +2483,18 @@ cmd_fetch(int argc, char *argv[]) if (!fetch_all_branches) fetch_all_branches = remote->fetch_all_branches; for (i = 0; i < remote->nfetch_branches; i++) { - got_pathlist_append(&wanted_branches, + error = got_pathlist_append(&wanted_branches, remote->fetch_branches[i], NULL); + if (error) + goto done; } } if (TAILQ_EMPTY(&wanted_refs)) { for (i = 0; i < remote->nfetch_refs; i++) { - got_pathlist_append(&wanted_refs, + error = got_pathlist_append(&wanted_refs, remote->fetch_refs[i], NULL); + if (error) + goto done; } } @@ -9287,8 +9291,10 @@ cmd_send(int argc, char *argv[]) } } else if (nbranches == 0) { for (i = 0; i < remote->nsend_branches; i++) { - got_pathlist_append(&branches, + error = got_pathlist_append(&branches, remote->send_branches[i], NULL); + if (error) + goto done; } }