commit cf032c44a2f1308d52ec68df3417e409f262ed45
from: Stefan Sperling <stsp@stsp.name>
via: Thomas Adam <thomas@xteddy.org>
date: Tue May 31 23:14:47 2022 UTC

ensure that all open basefd/accumfd get closed in got_repo_close()

found by tracey

commit - bfb5ee0b7372ae375143b9dee5552b8bec26cf05
commit + cf032c44a2f1308d52ec68df3417e409f262ed45
blob - 3fb28c2a556b23e57fb4c7d68445fa22cec08f52
blob + 0e3f94fa40530b3a7da3a2953d72393dce749ff8
--- lib/repository.c
+++ lib/repository.c
@@ -791,9 +791,8 @@ got_repo_close(struct got_repository *repo)
 	}
 
 	for (i = 0; i < repo->pack_cache_size; i++) {
-		if (repo->packs[i].path_packfile == NULL)
-			break;
-		got_pack_close(&repo->packs[i]);
+		if (repo->packs[i].path_packfile)
+			got_pack_close(&repo->packs[i]);
 		if (repo->packs[i].basefd != -1) {
 			if (close(repo->packs[i].basefd) == -1 && err == NULL)
 				err = got_error_from_errno("close");