commit d9cf08d99b88780ca686a001c3f6662da136829e from: Florian Obser via: Thomas Adam date: Thu Jul 21 08:32:00 2022 UTC We don't care about the length of the read line. Found by llvm's scan-build (dead store). OK stsp commit - 17c93e37adaf6ec18654a4d9cea0846a0d5394f3 commit + d9cf08d99b88780ca686a001c3f6662da136829e blob - f08817f49f0d99dacb040fde577b5148f600f223 blob + 4af7bb0cff2a2aef13a76674f3280da1f7a06765 --- got/got.c +++ got/got.c @@ -396,7 +396,6 @@ edit_logmsg(char **logmsg, const char *editor, const c const struct got_error *err = NULL; char *line = NULL; size_t linesize = 0; - ssize_t linelen; struct stat st, st2; FILE *fp = NULL; size_t len, logmsg_len; @@ -463,7 +462,7 @@ edit_logmsg(char **logmsg, const char *editor, const c } len = 0; - while ((linelen = getline(&line, &linesize, fp)) != -1) { + while (getline(&line, &linesize, fp) != -1) { if ((line[0] == '#' || (len == 0 && line[0] == '\n'))) continue; /* remove comments and leading empty lines */ len = strlcat(*logmsg, line, logmsg_len + 1); @@ -3933,7 +3932,6 @@ match_patch(int *have_match, struct got_commit_object const struct got_error *err = NULL; char *line = NULL; size_t linesize = 0; - ssize_t linelen; regmatch_t regmatch; *have_match = 0; @@ -3951,7 +3949,7 @@ match_patch(int *have_match, struct got_commit_object goto done; } - while ((linelen = getline(&line, &linesize, f)) != -1) { + while (getline(&line, &linesize, f) != -1) { if (regexec(regex, line, 1, ®match, 0) == 0) { *have_match = 1; break;