commit ebb42948df126b79ef0cff4ffb379c748f166ec0
from: Florian Obser <florian@narrans.de>
via: Thomas Adam <thomas@xteddy.org>
date: Thu Jul 21 08:32:00 2022 UTC

Don't chug along if repo format version is unsupported.

Found by llvm's scan-build (dead store).
OK stsp

commit - 399ea8e46abdd9182e61a56f5c42920cea716f1f
commit + ebb42948df126b79ef0cff4ffb379c748f166ec0
blob - ee9093dbcc252384d25fdce40f0631a837c3cf52
blob + 847387d2ceeaf787c46ee855838863d661357a96
--- lib/repository.c
+++ lib/repository.c
@@ -783,8 +783,10 @@ got_repo_open(struct got_repository **repop, const cha
 	err = read_gitconfig(repo, global_gitconfig_path);
 	if (err)
 		goto done;
-	if (repo->gitconfig_repository_format_version != 0)
+	if (repo->gitconfig_repository_format_version != 0) {
 		err = got_error_path(path, GOT_ERR_GIT_REPO_FORMAT);
+		goto done;
+	}
 	for (i = 0; i < repo->nextensions; i++) {
 		char *ext = repo->extensions[i];
 		int j, supported = 0;