commit f1553d4fd658ca1516a0a238c20ca62e675a3b95
from: Mark Jamsek <mark@jamsek.dev>
via: Thomas Adam <thomas@xteddy.org>
date: Tue May 02 15:22:14 2023 UTC

gotd: return early after disconnect on auth event error

This fixes a segv reported by Mikhail. In this path, any error is already
logged, client freed, and event_del() called so we don't need to cleanup
in done.

ok stsp@

commit - ef5fadfa178f61ca18c6f2ae0b8e7d93b26c991c
commit + f1553d4fd658ca1516a0a238c20ca62e675a3b95
blob - 879ce9726af53b2e3df4d2233b5fb6db82d2ce52
blob + b11c1c1acd745ba6f9cfa1b3e67e1d210de90fe9
--- gotd/gotd.c
+++ gotd/gotd.c
@@ -1118,7 +1118,7 @@ gotd_dispatch_auth_child(int fd, short event, void *ar
 			disconnect_on_error(client, err);
 		else
 			disconnect(client);
-		goto done;
+		return;
 	}
 
 	repo = gotd_find_repo_by_name(client->auth->repo_name, &gotd);