commit f2c54bde7775ee68219a71b9de403db863b58bbf
from: Florian Obser <florian@narrans.de>
via: Thomas Adam <thomas@xteddy.org>
date: Thu Jul 21 08:32:00 2022 UTC

Prevent memory leak when asprintf fails.

Found by llvm's scan-build.
OK stsp

commit - cfc8922bd7eff82e98dcc2d45945769a1a76806c
commit + f2c54bde7775ee68219a71b9de403db863b58bbf
blob - 5009ce41f8cd313d0ee2a6bba7d4a74c6fea58e8
blob + a299594e95978c54a3d007683921e5669c59f527
--- lib/object_create.c
+++ lib/object_create.c
@@ -455,8 +455,10 @@ got_object_commit_create(struct got_object_id **id,
 	}
 
 	if (asprintf(&author_str, "%s%s %lld +0000\n",
-	    GOT_COMMIT_LABEL_AUTHOR, author, (long long)author_time) == -1)
-		return got_error_from_errno("asprintf");
+	    GOT_COMMIT_LABEL_AUTHOR, author, (long long)author_time) == -1) {
+		err = got_error_from_errno("asprintf");
+		goto done;
+	}
 
 	if (asprintf(&committer_str, "%s%s %lld +0000\n",
 	    GOT_COMMIT_LABEL_COMMITTER, committer ? committer : author,