commit f57ea9f3db923c517242dcf1eed8948a71d8a67c
from: Josh Rickmar <jrick@zettaport.com>
via: Thomas Adam <thomas@xteddy.org>
date: Sat Aug 27 17:55:03 2022 UTC

don't create signed tag objects with trailing NUL

Although Git itself did not care, the superfluous NUL at the end of
the tag object was breaking GitHub's SSH signature detection.

ok stsp@

commit - 75716fd6ed1a99a0e601b2820363b17d7c0333a7
commit + f57ea9f3db923c517242dcf1eed8948a71d8a67c
blob - 2cac987f8e4af5c0e0ecaeda1b5b37e5c55952c9
blob + 3b36523bb3fec9888a0551282782e8ec8d39d163
--- lib/object_create.c
+++ lib/object_create.c
@@ -749,10 +749,7 @@ got_object_tag_create(struct got_object_id **id,
 		err = buf_load_fd(&buf, out_fd);
 		if (err)
 			goto done;
-		sig_len = buf_len(buf) + 1;
-		err = buf_putc(buf, '\0');
-		if (err)
-			goto done;
+		sig_len = buf_len(buf);
 		if (close(out_fd) == -1) {
 			err = got_error_from_errno("close");
 			goto done;