commit f64cf10ded89231621f05a9b05aabd596a63334a
from: Stefan Sperling <stsp@stsp.name>
date: Fri Aug 29 15:41:39 2025 UTC

log errors in just one place in login.c process_request()

commit - e112ed1d59eb471c749edac917491dbbcf366784
commit + f64cf10ded89231621f05a9b05aabd596a63334a
blob - 43e4facc484aba4c58ac40ab763f4be719880792
blob + 6bdcc9df4d1bed48fa079aab23a472e9fc2f15a7
--- gotwebd/login.c
+++ gotwebd/login.c
@@ -303,16 +303,13 @@ process_request(struct request *c, struct imsg *imsg)
 
 	/* parse our querystring */
 	error = gotweb_init_querystring(&qs);
-	if (error) {
-		log_warnx("%s: %s", __func__, error->msg);
+	if (error)
 		goto err;
-	}
+
 	c->t->qs = qs;
 	error = gotweb_parse_querystring(qs, c->querystring);
-	if (error) {
-		log_warnx("%s: %s", __func__, error->msg);
+	if (error)
 		goto err;
-	}
 
 	if (qs->login)
 		return do_login(c);
@@ -348,6 +345,7 @@ forward:
 	return 0;
 
 err:
+	log_warnx("%s: %s", __func__, error->msg);
 	free(hostname);
 	c->t->error = error;
 	if (gotweb_reply(c, 400, "text/html", NULL) == -1)