Commit Briefs

Thomas Adam

portable: release 0.100 (tags/0.100)


Thomas Adam

portable: CI: FreeBSD-14.0

Bump the CI testing for FreeBSD to use 14.0


Thomas Adam

bump version number


Thomas Adam

CHANGES for 0.100


Thomas Adam

sync dist file list


Thomas Adam

gotadmin sits in section 1, not 8



Thomas Adam

reintroduce the 'got init' command as an alternative to 'gotadmin init'

New users trying out Got for the first time have reported trouble with finding a way to create a new repository, based on their assumption that Got works like Git which provides a 'git init' command. It doesn't cost us much effort to keep this command available in both programs to make discovery a bit easier for new users coming from Git.


Thomas Adam

fix pack file transfers which do not use sidebands

Found while running 'got clone' against a git9 server, after an unrelated issue was reported by Lucas on IRC, thanks! ok op@


Thomas Adam

plug 'got diff obj1 obj2' line metadata memory leak

Despite API callers not requesting it, we collect line metadata due to NULL pointer checks missing a level of indirection. Reported by Kyle Ackerman. ok op and stsp


Thomas Adam

plug a leak in a few cmds: forgot to free(cwd) at the end

spotted while investigating for another leak spotted by Kyle Ackerman. ok stsp@ and jamsek




Thomas Adam

gotwebd: remove previd and prevset query string parameter

They're no longer used.


Thomas Adam

gotwebd: delete dead code

at this point we can't know if the client has disconnected, we just finished parsing the fcgi parameters and started handling the reply. We'll know whether the client disconnected only later, while trying to send the page content.


Thomas Adam

gotwebd: use the last matching fastcgi parameter

in case of multiple parameters with the same name, use the last matching one.



Thomas Adam

got{web,}d: handle multiple -v

only fatal*() and log_warn*() are now logged by default. log_info() is hidden behind a -v and log_debug behind -vv. Makes gotd and gotwebd way less chatty. ok stsp@


Thomas Adam

gotwebd: use less temp files

Instead of allocating a whole set of temp fd per `listen' directive, just use a global set per "sockets" process. This is fine since gotwebd doesn't keep multiple connections open at the same time, once it enters gotwebd_process_request() it won't exit until all the page has been processed. (this because we don't have async APIs for got operations.) ok stsp@


Thomas Adam

portable: remove SA_LEN/SS_LEN

These are no longer used now that upstream has changed its socket handling.


Thomas Adam

portable: macOS -- SOCK_CLOEXEC

Only use this flag #ifdefined.


Thomas Adam

portable: fix up log.c file location


Thomas Adam

remove a redundant bounds check which gets elided by clang

found by + ok op@