Commit Briefs

68ad340121 Stefan Sperling

CHANGES for 0.73 (tags/0.73)


619b3b4984 Stefan Sperling

document TOG_VIEW_SPLIT_MODE



400e716eb9 Stefan Sperling

sync distfile list






7881782691 Stefan Sperling

add -v option to 'got tag' usage string




2c986b8f7e Omar Polo

check for specific chars instead of using isspace(3)

Reminded by naddy and stsp; it was missing a cast to unsigned char to prevent issues on archs with signed chars and was too broad anyway. While here, drop an extra check immediately after. ok stsp@


888ae65035 Thomas Adam

got_date.h: add explicit #includes

Don't rely on implicit/"hidden" includes, but rather add them to the header file so their inclusion doesn't result in missing values. Although not explicitly a functional change, this does help -portable. This ensures size_t/time_t are always present. OK @jrick


5c5d88bfed Josh Rickmar

remove duplicate test_parseargs call

spotted by op@


a82759bba7 Josh Rickmar

fix echo/printf order and actually run the test


c632297d7b Josh Rickmar

Use pipe() which is a more understood syscall than pipe2() which doesn't

exist on MacOS, for instance. Since we we're passing in 0 to pipe2(), this mean no fcntl() flags were being sent. As such, it's the same syscall as pipe() which also has the added benefit that it's more portable. committing on behalf of thomas with my ok


2c0a0d66f9 Josh Rickmar

whitespace fix


91d845ad5d Josh Rickmar

fix tag signing when the key file does not exist

This should fail without creating any tag. Before, ssh-keygen(1) would print an error to stderr, but got would create an unsigned tag. ok op@



26e6f38e73 Stefan Sperling

rename got.conf(5) mirror-references to mirror_references for consistency

Existing configuration files will keep working for now since the old name with dashes is still recognized by the config parser.


f1bf60d10a Stefan Sperling

rename got.conf(5) fetch-all-branches to fetch_all_branches for consistency

Existing configuration files will keep working for now since the old name with dashes is still recognized by the config parser.


a6d37facd3 Mark Jamsek

tog: add C-g/backspace key map to abort compound cmds

Problem reported by stsp: 9999j would tie up tog till completed. While here, trim trailing whitespace in tog.1 and make C-g alias existing backspace abort key map for search and G in log view. ok op@ and stsp@


49b24ee549 Mark Jamsek

tog: expand horizontal split support to all views

With this, hsplits are now available to the same parent/child view combinations as vsplits. Includes OB1 log truncation fix from op@ that was reported by stsp. ok stsp@


4d5ee9564a Josh Rickmar

create and verify tags signed by SSH keys

This adds a new -s flag to 'got tag' that specifies the signer identity (for example, a key file) of the tagger. The tag object will include a signature that validates each of the tag object headers and the tag message. Verifying these signed tags requires maintaining an allowed signers file which maps signer identities (i.e. the email address of the tagger) to SSH public keys. See ssh-keygen(1) for more details of the allowed signers file. After creating this file and providing the path to it in got.conf(5) using the allowed_signers option, tags may be verified using with 'got tag -V tag_name'. The return code will be non-zero if a signature fails to verify. ok stsp@


6c77e03376 Omar Polo

fix imsg_add TREE_ENTRY: Result too large on i386

There's a math error when computing the size of one entries in the batching code. Reported by semarie, ok semarie stsp