Commit Briefs

dad80d9b37 Omar Polo

gotwebd: start to implement the auth feature (gotwebd-auth)

rearranged the code a bit; let's use a bufferevent since we're not going to use imsg for this anyway. for now it just replies back with a dummy URL.

diff | patch | tree

4ac134683f Omar Polo

gotsh: fix usage

diff | patch | tree

ff2b55acc0 Stefan Sperling

add an auth process to gotwebd (WIP: it receives requests, but does nothing)

diff | patch | tree

e39d79e3c6 Stefan Sperling

implement gotsh weblogin command

diff | patch | tree

7131385900 Kyle Ackerman

Plug some memory leaks in got-{send,fetch}-pack

my_capabilities was leaked in both got-send-pack and got-fetch-pack and needed freeing it in both. ok op@

diff | patch | tree

493d280daf Stefan Sperling

revert part of previous commit which wasn't actually needed for memleak checks

diff | patch | tree

40538e52bf Stefan Sperling

fix all remaining gotwebd leaks the regress memleak checker was flagging

diff | patch | tree

cab13f2dcc Stefan Sperling

free gotweb.c iev_server on shutdown

diff | patch | tree

53bbd7ac83 Stefan Sperling

also clear iev_gotweb->ibuf before exit to appease the memleak checker

diff | patch | tree

178d4e2e7f Stefan Sperling

free iev_gotweb before exiting; harmless leak but 'make regress' flags it

diff | patch | tree

2bca46599e Stefan Sperling

reduce the send_response() timeout

For some reason this timeout was blocking long enough to make other waiting client connections time out. Reduce the amount of retries.

diff | patch | tree

3b8dccc5eb Stefan Sperling

track per-request connection state in struct request, not struct socket

diff | patch | tree

18f076f0b4 Stefan Sperling

do not keep re-arming the accept pause timer in gotwebd if already armed

diff | patch | tree

a51f669c12 Stefan Sperling

log fcgi requests which have timed out

diff | patch | tree

6a6496627c Stefan Sperling

expose error status of gotweb_process_request() to the caller

diff | patch | tree

d4261a58ad Stefan Sperling

fix read error handling in gotweb_render_patch() and check error before writing

diff | patch | tree

96aa828c56 Stefan Sperling

fix previous commit (build breakage)

diff | patch | tree

a8ae7cb134 Stefan Sperling

do not send fcgi end record trailer to broken connections

diff | patch | tree

49048dfff7 Stefan Sperling

fix error handling in fcgi_forward_response()

diff | patch | tree

7b3e353331 Stefan Sperling

make writes in fcgi_forward_response() time out to avoid gotwebd getting stuck

diff | patch | tree

f8b1e9c78b Stefan Sperling

set CLOEXEC and NONBLOCK flags on the pipe between server and gotweb procs

diff | patch | tree

2bd8d56a2d Stefan Sperling

stop using EV_PERSIST for fcgi_request and fix error handling

diff | patch | tree

f624e3f7a3 Stefan Sperling

fix format string specifier for c->request_id

diff | patch | tree

a07ec64aa1 Stefan Sperling

remove gotwebd-specific libexec helpers

gotwebd now uses the same set of libexec helpers as used by got and tog. ok op@

diff | patch | tree

b27be572b3 Stefan Sperling

split gotwebd into a server process and a gotweb process

As before, the server process accepts incoming FCGI requests and runs in the web server's chroot. The gotweb process runs outside chroot. This allows for browsing repositories anywhere on the file system, saving disk space on servers and avoiding a repository eynchronization delay. The gotweb process runs libexec helpers installed in /usr/local. Installing static binaries in the chroot is no longer needed for gotwebd to function. This helps -portable. gotwebd now defaults to a new user account, _gotwebd, though the www user can still be used if desired. The gotwebd.conf repos_path directive is no longer relative to the chroot directory but is now an absolute path. Existing configs may need to be adjusted accordingly. ok op@

diff | patch | tree