Because copy_ref_delta() was forgetting to update the *outsize output parameter, when clients sent ref-deltas gotd was miscalculating the on-disk size of the pack file and would report "bad offset in pack file" if an object was stored at an offset beyond the miscalculated smaller size.

Fixes regress failures due to 'git gc' complaining, as of 2.50.0: '# pack-refs with:' does not start with '# pack-refs with: ' reported by naddy@ ok op@

Could be triggered by running 'got fetch' with a "send" block in got.conf. The functions free_fetch_config() and free_send_config() were freeing data via the global "remote" variable instead of their own argument as intended. Patch by Renato Aguiar

This feature can be used by server administrators to override or augment access permissions set in gotsys.conf if needed.

Deny rules in gotsys.conf didn't actually work until recently and were lacking test coverage.

This can be observed during 'got send' or 'gotadmin pack/cleanup' in some cases. We would keep processing the same parent commits over and over.

Deny rules do not contain the rw/ro authorization mode string. Do not fail if that string is missing. Corresponding tests will be added soon.

This can be observed during 'got send' or 'gotadmin pack/cleanup' in some cases. We would keep processing the same parent commits over and over.

We should assume that gotd is always running, and we should not be automatically restarting gotd if it has crashed. This misfeature was added early to make setup of the gotsysd regression test suite easier. It was only half working since the attempt to connect to gotd's unix socket after starting it failed due to pledge violations.

Do not close the pipe to gotsysd before trying to send an error message to gotsysd. Print errors to stderr as a last resort.

It seems flushing our final message can fail if we forcefully exit the event loop here. This would leave gotsysd's sysconf process stuck in a state where it was waiting for a message which never arrived.

The gotsysd_imsg_flush() wrapper enforces a sync write by polling the file descriptor and writing data in a loop. Since libevent already does polling for us we can simply use imsgbuf_flush() here instead.

THe main process will always send these messages so don't skip parsing them even if we are going to ignore the current user.

The -q option suppresses too many important errors, including the warning printed when a host key has changed. Requiring users to pass -v in order to see this message is too cumbersome.