Commits


forbid the '$' and '#' symbols in gotsys.conf reference names These symbols are also part of configuration file syntax and should therefore be avoided.


update gotwebd favicons to show the smiley fish only


document additional reference name restriction details in git-repository.5


document restrictions imposed on reference names in gotsys.conf


introduce gotsys_ref_name_is_valid() We need to enforce additional restrictions on reference names specified in gotsys.conf in order to prevent escaping to arbitrary gotd.conf syntax. Add test coverage.


remove hidden gotsys.conf draft text about a "publish" directive This directive will not be implemented in the final design. Instead we will be adding authentication to gotwebd with associated config syntax.


show examples for reference protection rules in gotsys.conf manual


remove (undocumented) support for setting an SMTP relay in gotsys.conf SMTP relays for email notifications will only be configured server-side.


remove a TODO item that is done


do not clobber changes staged via stage -p during 'got revert' While we must install staged blob contents during revert if there are staged changes, the base blob ID recorded in the file index must always reflect the actual base blob from the base commit. Setting the base blob ID to that of a staged blob causes problems. The staged blob's ID is tracked in a separate field. ok op@


fix test failures related to clone -a introduced with previous commits Use a dedicated flag to keep track of HEAD ref creation state, rather than checking pe == NULL.


do not report the default branch as ignored in debug log, we will fetch it


attempt to create HEAD reference in case the server did not announce a symref


only pick a non-symbolic HEAD reference as the default branch to fetch


pick a default branch to clone when the server does not advertise HEAD symref Avoids the need to use got clone -b to get anything at all from a server implementation which does not advertise a HEAD symref. Patch by martijn@


fix gotd branch protection rejecting commits that already exist on server When a reference update sends an empty pack file because the objects already exist on a different branch, gotd was wrongly rejecting the reference update. The logic which protects references from moving kicked in, but didn't account for this particular case. Run a YCA check to ensure the client is only appending new commits to the branch and allow the ref update to proceed if so. Add test coverage. Problem reported by martijn@


fix bogus "bad offset in pack file" errors wrongly raised by gotd Because copy_ref_delta() was forgetting to update the *outsize output parameter, when clients sent ref-deltas gotd was miscalculating the on-disk size of the pack file and would report "bad offset in pack file" if an object was stored at an offset beyond the miscalculated smaller size.


add a TODO item for a bug between stage -p and revert


make our pack-refs header format align with the expectations of git 2.50.0 Fixes regress failures due to 'git gc' complaining, as of 2.50.0: '# pack-refs with:' does not start with '# pack-refs with: ' reported by naddy@ ok op@


bump version number


CHANGES for 0.115


fix segfault due to double-free in got-read-gotconfig Could be triggered by running 'got fetch' with a "send" block in got.conf. The functions free_fetch_config() and free_send_config() were freeing data via the global "remote" variable instead of their own argument as intended. Patch by Renato Aguiar


add global repository access rules to gotsysd.conf This feature can be used by server administrators to override or augment access permissions set in gotsys.conf if needed.


add a test case for deny rules in gotsys.conf Deny rules in gotsys.conf didn't actually work until recently and were lacking test coverage.


fix looping in got-read-pack's version of repaint_parent_commits() as well This can be observed during 'got send' or 'gotadmin pack/cleanup' in some cases. We would keep processing the same parent commits over and over.