Commit Briefs


Thomas Adam

gotwebd: urlencode also the double quote character

URLs are embedded as part of the HTML and, while it seems legal from RFC3986 to leave that character unquoted, we need it quoted to avoid breaking the HTML output. ok tracey@


Thomas Adam

gotwebd: templateify gotweb_render_tree

ok tracey@


Thomas Adam

gotwebd: css: fix horizontal overflow in blob and blame pages

spotted by + "looks good" tracey@


Thomas Adam

gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs

binary blobs are automatically redirected to the BLOBRAW page (which is the old BLOB.) ok jamske


Thomas Adam

provide a getline-style function for blobs

ok jamsek


Thomas Adam

revoke filesystem access in gotd listen process via unveil(2)

This should avoid involuntary use of bind(2) with arbitrary socket paths. ok op@


Thomas Adam

expose 'gotctl info' output only to the root user

Now that anyone can connect to the socket, it is probably safer to expose information about currently connected clients only to root.


Thomas Adam

gotwebd.conf: use `listen on socket' syntax for UNIX sockets too

and drop unix_socket and unix_socket_path in server context. ok stsp@


Thomas Adam

remove the gotsh group requirement from gotd; any user can now connect

Repository access is now controlled by access rules in gotd.conf, and concurrent connections to the gotd socket by local users are limited by the listen process. We should keep refining our anti-DoS measures in the future, but at least we have something in place now. ok jamsek, op


Thomas Adam

gotwebd: rework got_output_file_blob, no functional change

can now use got_object_blob_is_binary to simplify the logic. ok stsp@


Thomas Adam

add got_object_blob_is_binary function

needed for future use by gotwebd. ok stsp@



Thomas Adam

gotwebd: remove erratic horizontal scrolling

In some pages gotwebd shows horizontal scrollbars because the error message overflows the width. Remove the explicit width in the CSS, the message is still rendered fine and doesn't overflow the page. spotted by and ok tracey@


Thomas Adam

simplify gotd' timeouts string parsing

no need to duplicate what strtonum does; pass the *real* maximum value allowed to it directly. ok stsp@


Thomas Adam

change gotweb_render_content_type argument type to const char *

it's a string, `const char *' is fine (and what all the callers use anyway.)


Thomas Adam

gotwebd: use Content-Disposition for RSS; sets the filename

Since gotwebd serves the RSS from a path without a file name component, browsers just make up a random string to give the file a name which can be confusing. Furthermore, since it's served as application/rss+xml they try to render the XML (failing.) Use gotweb_render_content_type_file (which sets the Content-Disposition HTTP header) to fix both: the feed is now called <repo-name>.rss and set as attachment (thus saved and not rendered.) Change the function to take an optional filename suffix for the occasion. ok jamsek


Thomas Adam

gotd: allow to express timeouts using minutes/hours

This allows to use a suffix to indicate the unit of measure, such as "1h" for one hour or "30m" for 30 minutes. The suffix "s" for seconds is also accepted for completeness. ok stsp


Thomas Adam

enforce gotd request timeout > 0; the code doesn't handle zero right now

spotted by + ok op@


Thomas Adam

gotwebd: tweak gotweb_render_content_type_file parameters type

`type' and `file' are strings so use `const char *' for both.


Thomas Adam

add conf_limit_user_connection prototype at the top of parse.y

different yacc implementations (e.g. GNU bison) may put the various parts in a different order, and so the definition of the function may not be visible in the generated code.


Thomas Adam

introduce connection options to gotd.conf

Allow administrators to tweak the default authentication and request timeouts if needed, and to tweak the limit of concurrent connections for specific user accounts. with several tweaks from and ok op@



Thomas Adam

portable: move tmpl.h to EXTRA_DIST

This header isn't needed for direct compilation, but should be included as part of the main tarball.


Omar Polo

portable: gotwebd: add tmpl.h to gotwebd_SOURCES

unbreaks `make dist'