Commit Briefs
prevent useless EEXIST errors filling up the global custom error array
While checking out files, do not attempt to create every directory that exists in the repository tree without paying consideration to their existence on disk. Instead, let functions which add files worry about creating any missing parent directories. This shakes out two other bugs in broken symlink installation code which ended up passing an absolute path to add_dir_on_disk() and forgot to report progress in an unreachable code path that is now getting used. Problem reported by + ok naddy@
plug got_object_id leak in cmd_log()
backport of b161263abf48e69eb1f05028b633808dfe337357 to cvg
plug got_object_id leak in cmd_log()
ok stsp@
gotadmin cleanup: don't delete pack files that are too young
similar to what we do for loose objects, avoid deleting pack files that were created "too soon" unless -a is given. This prevents races when gotadmin load, got fetch or gotd are installing a new pack file and a concurrent gotadmin clean attempts to remove it. ok stsp
purge_redundant_pack(): don't special-case .pack or .idx
leftover, the error handling of unlink() a couple of lines below used to carry a similar special-casing but was dropped; drop it here too.
take reachability in consideration when cleaning redundant packfiles
This wraps the cleaning up of loose objects and redundant pack files under a new functions, making the _prepare() and _complete() functions unnecessary. It walks the reachable commits unconditionally since that information is always needed and adapt how we purge loose objects after this change. The progress function is changed too and we log `ncommits' first, followed by the number of loose objects, followed by the rest. Pack files are now considered redundant when all their objects are provided by a bigger pack or are unreachable. ok stsp
make 'gotadmin load' always read data from standard input
This provides better symmetry with 'gotadmin dump', and allows us to pass the list of references as command line arguments, replacing the -b option. The -l option now takes an argument which specifies the bundle file rather than requiring data to be fed on stdin with -l which feels awkward. ok op@
gotadmin load: don't add a newline when listing refs
the newline is only needed after the progress output, which is not present in the 'listing refs' case.
add an initial implementation of gotadmin load
it is intended to be the counterpart of `gotadmin dump' and, just like it, there's planned support for handling fast-import stream. At the moment it only deals with git bundles. ok stsp
plug leak in got_fetch_pack error path
set err and goto done instead of an early return that leaks various things. ok jrick
make gitwrapper ignore 'permission denied' for repository paths
We recommend that gotsh users should not have direct filesystem access to repositories served by gotd. Which means admins will be setting things up as follows if public read-access should be denied: chown _gotd /git chmod 700 /git su -m _gotd -c 'gotadmin init /git/repo.git" However, gitwrapper would error out when repositories listed in gotd.conf were inaccessible to the user invoking gitwrapper: git-upload-pack: /etc/gotd.conf:2: realpath /git/repo.git: Permission denied Make gitwrapper ignore such errors as they are expected in this situation. While here, add a PROC_GITWRAPPER process ID for use as a global variable parse.y can check while special-casing any specific behaviour required by gitwrapper. (The worse alternative would have been adding a new global variable to parse.y just to control the behaviour on realpath errors.) ok op@