Commit Briefs

Thomas Adam

reuse a temporary file across commits during got log -p -S

suggested by + ok op@



Thomas Adam

add a missing .Pp to got.1



Thomas Adam

add one-line output mode to got log with -s flag

-s for short. Moves log search to -S. Patch by Evan Silberman


Thomas Adam

revert object enumeration in got-read-pack for now; needs more work

This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@


Thomas Adam

in enumeration_request(), use the correct index for tagged commit objects

Fixes an error where got-read-pack errors out with "bad object data" during 'got send' because we ended up handing a tag object to the commit object parser.


Thomas Adam

free id and path in load_packed_tree_ids() on error, else they would leak

pointed out by op@




Thomas Adam

implement object enumeration support in got-read-pack

ok op@


Thomas Adam

got stage: implicitly unstage when staging the reverse of the staged diff

otherwise we end up with a staged empty edit for that file. ok stsp@



Thomas Adam

convert delta cache to a hash table

This approach uses more memory but is much faster. To offset the additional memory usage somewhat the cache now stores very small deltas only. However, overall memory usage goes up. Hopefully we will find a way to reduce this later. ok op@



Thomas Adam

don't pass $ret to test_done on failure when it's known to be zero

Otherwise the test directory it's not left in place; ok tracey@


Thomas Adam

properly swap cached struct pack array elements in got_repo_cache_pack()

Avoids clobbering open files for delta base/accumulation, leaking file descriptors, and triggering errors from close(2) during got_repo_close() as we try to close the same file descriptor more than once.


Thomas Adam

move creation of tempfiles outside of lib/diff.c

ok tracey


Thomas Adam

map delta cache file into memory if possible while writing a pack file

with a fix from + ok op@


Thomas Adam

portable: fix-up sha1.h include

-portable doesn't need this directly.



Thomas Adam

reduce GOT_PACK_CACHE_SIZE to 32, otherwise it uses too many open files

found by tracey


Thomas Adam

ensure that all open basefd/accumfd get closed in got_repo_close()

found by tracey


Thomas Adam

open temporary files needed for delta application in got_repo_open()

This prepares for callers of got_repo_open() that cannot afford to open files in /tmp, such as gotwebd. In a follow-up change, we could ask such callers to pass in the required amount of open temporary files. One consequence is that got_repo_open() now requires the "cpath" pledge promise. Add the "cpath" promise to affected callers and remove it once the repository has been opened. ok tracey