Commit Briefs
simplify got_gotweb_openfile/flushfile
Return only the FILE *, and require only that to close subsequently. Having to manage the file descriptor too makes using these functions unnecessary complex. millert@ agrees
simplify previous; avoid temporary string
blind ok stsp@
show reference labels next to commit messages in tog log view
requested by mpi@ ok op@
fix wrong assumption about author timestamp in test_blame_lines_shifted_skip
Not all commits will share the same author timestamp. This test would fail when run at the wrong time of day as found out by op@'s regress runner. ok op@
sync files from diff.git f46fa9b5e78156c0360f508336dbe3dfa04b503f
Do not treat \r\n line endings as special.
gotd: return early after disconnect on auth event error
This fixes a segv reported by Mikhail. In this path, any error is already logged, client freed, and event_del() called so we don't need to cleanup in done. ok stsp@
gotwebd: fix logic error and skip again some entries in the index
logic error introduced in df2d3cd25 ok stsp@
do not forget to flush after writing a cached fulltext to a temporary file
Fixes the following error during gotadmin pack -a: gotadmin: raw object has unexpected size
tog regress: TAB instruction + test for diff J keymap
Add the TAB instruction to the test harness, and a test case for the previous commit: scroll down the log from the diff view with the J keymap when on the last loaded commit. ok stsp@
tog: resize log view if toggling fullscreen from child view
We call resize_log_view() when toggling 'F'ullscreen from the log view, but forgot to do this when toggling fullscreen from a child view if its parent is the log view. This fixes a bug that prevents scrolling down the log view from the diff view with the J keymap if already on the last loaded commit. Regress test in the following commit. ok stsp@
tog: mark HSPLIT_SCALE as float; unbreak regress on i386
On i386 view_split_begin_y() computed a value slightly different than on other arches, breaking the regress. Casting HSPLIT_SCALE as float unbreaks it. Diff from jamsek, committing on his behalf. Thanks!
tog: open screendump file early during regress
we can't open arbitrary files after unveil(), and that's a feature! So, open it early and truncate it before use just in case screendump() ends up being called more than once. ok/tweak stsp, ok jamsek
tog: don't check whether stdin is a tty during regress
ok stsp, jamsek
tog: don't open /dev/tty during regress
as it might not be there (for e.g. if ran under cron). Reuse instead /dev/null since it's not expected to get input from stdin. ok jamsek