Commit Briefs

19a06f5a74 Stefan Sperling

CHANGES for 0.116 (tags/0.116)

diff | patch | tree

3a34ebda2e Stefan Sperling

sync dist file list

diff | patch | tree

87a2e886e5 Stefan Sperling

add missing include of stddef.h for ptrdiff_t in gotsys/parse.y

diff | patch | tree

c0ceb4cc12 Stefan Sperling

use standard integer type in validate_hmac_secret(); from op@

diff | patch | tree

7da96131eb Stefan Sperling

use a better idiom to find a NUL-terminator; from op@

diff | patch | tree

4f3d4d3a79 Stefan Sperling

add missing casts to ctype function arguments in gotsys parse.y

spotted by op@

diff | patch | tree

8b4b261f28 Stefan Sperling

add support for notifications to gotsysd and gotsys.conf

gotsys.conf now supports email and HTTP/JSON notifications ok op@

diff | patch | tree

41fda6f0f9 Stefan Sperling

fix gotsysd behaviour when the anonymous user is removed from gotsys.conf

The gotsys-useradd process would run into a bogus error regarding an invalid user name "anonymous" instead of locking the anonymous user account as expected. Add test coverage.

diff | patch | tree

4b6c492110 Stefan Sperling

replace ftruncate+lseek with equivalents from opentemp.c, where available

diff | patch | tree

cf66e481a7 Stefan Sperling

rename test "large loose objects" to "large files"

We might have more large file test cases eventually. And the existing test involves packing the loose objects. So the former name was not ideal.

diff | patch | tree

459c522ff2 Stefan Sperling

fix off-by-one during deltification in maximum stretch size calculation

Fix an off-by-one which causes invalid deltas to be written when common file sections exceed the maximum size which can be represented in a base-copy delta operation. This bug causes an invalid pack file to be written which neither gotadmin nor git will index successfully. Add a test which triggers the problem: got-index-pack: delta application result size mismatch: \ actual: 65536 expected: 16777216: bad delta ok op@

diff | patch | tree

5bbc921fd6 Stefan Sperling

show expected and actual sizes when delta application fails

ok op@

diff | patch | tree

fc3816d117 Stefan Sperling

avoid clobbering earlier errors in got_delta_apply and got_delta_apply_in_mem

ok op@

diff | patch | tree

ae784b42e0 Stefan Sperling

fix more missing resets of file position to zero after truncating files

ok op@

diff | patch | tree

590e374631 Stefan Sperling

reset file position when reusing per-repository temporary files

When reusing a temporary file, do not forget to reset its file position to zero. Otherwise, opening multiple raw objects in a row can fail during delta application with an unexpected file size reported by stat(2). Problem reported by Aaron Lin Problem reproduced and fix verified with a repository provided by Aaron. I have unsuccessfully tried to write a regression test for this. ok op@

diff | patch | tree

529f16d393 Stefan Sperling

fix lseek(2) calls which had "offset" and "whence" arguments swapped

diff | patch | tree

c506644a01 Stefan Sperling

fix gotd reload when /etc/gotd-secrets.conf is used

When sending the configuration to the newly reloaded gotd process we must send the path to the secrets file if it is being used. Otherwise, the new process will die with "unexpected amount of data received in imsg" errors. Test coverage will be added later as part of some new gotsysd tests which I have in progress.

diff | patch | tree

c63cd1cb97 Stefan Sperling

fix 'gotctl reload -s secrets' failing once gotd has failed to reload once

Reset reload secrets state on reload failure, such that the next reload attempt will not be rejected with an 'unexpected imsg' error.

diff | patch | tree

82e9b6ff0a Stefan Sperling

forbid the '$' and '#' symbols in gotsys.conf reference names

These symbols are also part of configuration file syntax and should therefore be avoided.

diff | patch | tree

ce39a4c074 Stefan Sperling

update gotwebd favicons to show the smiley fish only

diff | patch | tree

514c147c9a Stefan Sperling

document additional reference name restriction details in git-repository.5

diff | patch | tree

59d7decb8c Stefan Sperling

document restrictions imposed on reference names in gotsys.conf

diff | patch | tree

00fc2bb909 Stefan Sperling

introduce gotsys_ref_name_is_valid()

We need to enforce additional restrictions on reference names specified in gotsys.conf in order to prevent escaping to arbitrary gotd.conf syntax. Add test coverage.

diff | patch | tree

97b40d32ed Stefan Sperling

remove hidden gotsys.conf draft text about a "publish" directive

This directive will not be implemented in the final design. Instead we will be adding authentication to gotwebd with associated config syntax.

diff | patch | tree

0cb1fb1b61 Stefan Sperling

show examples for reference protection rules in gotsys.conf manual

diff | patch | tree