Commit Briefs
gotwebd: avoid needless double fseek()
got_gotweb_closefile() already takes care of rewinding before truncating and closing, so no need to replicate here. ok stsp@
gotwebd: lower log priority of unexpected disconnections
no need to be so loud when a client disconnects earlier than expected, log it only in verbose mode. Don't log GOT_ERR_CANCELLED too since that is only used to communicate the callers that we need to stop. ok stsp@
got_operations.c: use consistently a space before labels
makes diff prettier and easier to read; instead of the label we have the function name in the hunk line.
tog: fix segfault in draw_commit
build_refs_str() can succeed returning a NULL string if a commit has some refs pointing to it but that were all filtered out, resulting in a NULL-deref. ok stsp@
remove fsync() from got_gotweb_closefile()
discussed with millert@
rename got_gotweb_flushfile -> got_gotweb_closefile
suggested and ok millert@
make got_gotweb_flushfile always close the file
ok millert@
simplify got_gotweb_openfile/flushfile
Return only the FILE *, and require only that to close subsequently. Having to manage the file descriptor too makes using these functions unnecessary complex. millert@ agrees
simplify previous; avoid temporary string
blind ok stsp@
show reference labels next to commit messages in tog log view
requested by mpi@ ok op@
fix wrong assumption about author timestamp in test_blame_lines_shifted_skip
Not all commits will share the same author timestamp. This test would fail when run at the wrong time of day as found out by op@'s regress runner. ok op@
sync files from diff.git f46fa9b5e78156c0360f508336dbe3dfa04b503f
Do not treat \r\n line endings as special.
gotd: return early after disconnect on auth event error
This fixes a segv reported by Mikhail. In this path, any error is already logged, client freed, and event_del() called so we don't need to cleanup in done. ok stsp@
sync dist file list (tags/0.88)