Commit Briefs

Thomas Adam

portable: remove stray .orig files

These shouldn't have been commited, and probably predate when the .gitignore file was updated to filter out .orig files.


Thomas Adam

portable: gotwebd: add headers to EXTRA_DIST

Add the header files under gotwebd to EXTRA_DIST so that they're included in the distribution tarball.


Thomas Adam

portable: update READMEs with release info

Document how to release a new `-portable` version.


Thomas Adam

portable: explain how to sync/update -portable

Add a section to the README files explaining how -portable is maintained.


Thomas Adam

portable: maintscript: add GH remote

Ensure that the remote GH repo is fetched from.


Thomas Adam

Prevent use-after-free of packed_refs_path in error path.

Found by llvm's scan-build. OK stsp


Thomas Adam

Prevent memory leak when asprintf fails.

Found by llvm's scan-build. OK stsp


Thomas Adam

Make sure got_repo_pack_fds_close() frees a malloc'ed pointer.

Found by llvm's scan-build (bad free). OK stsp


Thomas Adam

If the first readdir() returns NULL err is uninitialized.

This can't happen in practice, but llvm's scan-build doesn't know this. OK stsp


Thomas Adam

We don't care about the length of the read line.

Found by llvm's scan-build (dead store). OK stsp


Thomas Adam

Do not ignore error from got_pathlist_append.

Found by llvm's scan-build (dead store). OK stsp


Thomas Adam

Do not ignore error from format_author().

Found by llvm's scan-build (dead store). OK stsp


Thomas Adam

Dot not ignore error from got_object_id_str().

Found by llvm's scan-build (dead store). OK stsp


Thomas Adam

path_got is unused and never assigned, no need to free it

OK stsp


Thomas Adam

Do not ignore I/O errors.

Found by llvm's scan-build (dead store). OK stsp


Thomas Adam

Don't chug along if repo format version is unsupported.

Found by llvm's scan-build (dead store). OK stsp



Thomas Adam

tog: blame view keymap to open log of annotated line

As per stsp's TODO item: open a log view of the selected line with 'L'. helped by and ok stsp@



Thomas Adam

document pull request workflow in got.1 man page

With permission from Jelmer Vernooij to use my pull request config for Dulwich, and Jelmer's name, as a real-life example. ok tracey, jamsek


Thomas Adam

typo in cat_commit

otherwise prints the author instead of the committer


Thomas Adam

tog: alias J and K to > and < keybindings for diff view

Use J and K to move to the next and previous commits, respectively, when the diff is loaded from the log or blame views. Patch by Mikhail ok stsp@


Thomas Adam

got commit: add flag to specify the author

This adds a new flag, `got commit -A', that allows to specify the commit author but retains the "committer" (which is obtained as usual via GOT_AUTHOR, got.conf or git config.) with lots of help from and ok stsp


Thomas Adam

portable: remove imsg.h

Allow imsg.h to be checked for portably.