Commit Briefs
add O_CLOEXEC (close-on-exec) to openat(2) calls
suggested by millert ok thomas_adam
add O_CLOEXEC (close-on-exec) flag to open(2) calls
suggested by millert ok thomas_adam
add "e" (close-on-exec) flag to fopen(3) calls
suggested by millert ok thomas_adam
tog: clear search highlighting when reloading view
Clear the search highlighting when replacing the content of a diff view ('<', '>', '[', ']', 'a', 'w') or a blame view ('b', 'p', 'B'). Previously the position would remain highlighted even if the text there had changed. ok stsp@ or a blame view
sort paths in got log -Pp and tog's diff view the same way as in the diff
reported by and fix confirmed by naddy
ignore the return value of closefrom(2); patch by Anna a.k.a. CyberTailor
millert@ suggests that this check is not needed, and that ideally we should be using close-on-exec instead. I will look into this, but in the meantime this change will help -portable: https://bugs.gentoo.org/828003
Release 0.64 (tags/0.64)
portable: remove queue.h
queue.h is included portably, so it shouldn't be included directly.
portable: enable merge.sh
This seemingly went walkies, so reenabling it.
regress: make merge.sh more POSIXy
Don't use '==' for equality matching in sh, as this won't work across all shells. ok @naddy
portable: running tests when shell is dash
Ubuntu's default shell is dash, when using /bin/sh. The portable nature of got is such that "$OSTYPE" to determine the host type (linux, bsd, etc.) is bash-specific and is not part of POSIX. autotools already provide a mechanism for determining the underlying platform type, and PLATFORM is already a subst value. Therefore, let the -portable parts of the regress test-suite use $PLATFORM to look at the underlying OS type. The tests themselves already expect /bin/sh to be POSIX-compliant in all other areas, so there should be no need to change the #! lines.
regress: cleanup: bypass sed wrapper
The sed portable wrapper works for inplace editing, but isn't required for just a single stream.
regress: make test operands POSIX compliant
Since the interpreter for the regress shell scripts are using /bin/sh this will usually imply some level of POSIX compliance (that isn't bash-specific, for instance). Some systems use dash as their sh shell and as such is stricter POSIX compliance. To help -portable, make the shell test checks use a single '=' for equality, rather than '=='.