Commit Briefs

Thomas Adam

got patch: use ints for line offsets instead of longs

ints have the advantage that their size is more likely to be the same across the various architecture supported by OpenBSD, thus introducing less possible differences. INT_MAX is still (at least) a few order of magnitudes higher than the patches we dealt with (even abnormal ones.) suggested by stsp@


Thomas Adam

actually guarding against negative line offsets

previous commit looked at some pretty zeroes returned from calloc instead of the actual numbers received.


Thomas Adam

style; set datalen only once


Thomas Adam

got patch: guard against invalid (negative) line offsets

under normal circumstances got-read-patch can't send negative line offsets; that's not an excuse not to guard the main process from those as well. This makes sure we bail out early instead of trying to apply the diff.


Thomas Adam

free patch on error




Thomas Adam

Bring back object enumeration inside got-read-pack as a fast path.

The problem that was found in the earlier version has been fixed. ok op@


Thomas Adam

portable: remove endian.h

This is included portably.




Thomas Adam

adjust expected test output after got log -s changes

ok op@


Thomas Adam

make got log -s show committer date

ok op@


Thomas Adam

make got log -s display local reference names

ok op@


Thomas Adam

in tog, rework Ctrl+u/d to scroll by half a page, and drop d/u again

This matches actual behaviour of less(1) for Ctrl+u/d, and leaves d/u free for potential future use. Suggested by naddy. Patch by Mark Jamsek


Thomas Adam

got log: sync match_commit from tog

So that 'got log -S' can match also the author and committer name, and the commit ID too. ok stsp@




Thomas Adam

reuse a temporary file across commits during got log -p -S

suggested by + ok op@



Thomas Adam

add a missing .Pp to got.1



Thomas Adam

add one-line output mode to got log with -s flag

-s for short. Moves log search to -S. Patch by Evan Silberman


Thomas Adam

revert object enumeration in got-read-pack for now; needs more work

This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@


Thomas Adam

in enumeration_request(), use the correct index for tagged commit objects

Fixes an error where got-read-pack errors out with "bad object data" during 'got send' because we ended up handing a tag object to the commit object parser.