Gotweb

This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@

diff | patch | tree

2 years ago Stefan Sperling

in enumeration_request(), use the correct index for tagged commit objects

Fixes an error where got-read-pack errors out with "bad object data" during 'got send' because we ended up handing a tag object to the commit object parser.

diff | patch | tree

2 years ago Stefan Sperling

free id and path in load_packed_tree_ids() on error, else they would leak

pointed out by op@

diff | patch | tree

2 years ago Stefan Sperling

fix wrong line wrap; pointed out by op@

diff | patch | tree

2 years ago Stefan Sperling

imsg_add() already frees wbuf on error; pointed out by op@

diff | patch | tree

2 years ago Stefan Sperling

implement object enumeration support in got-read-pack

ok op@

diff | patch | tree

2 years ago Omar Polo

got stage: implicitly unstage when staging the reverse of the staged diff

otherwise we end up with a staged empty edit for that file. ok stsp@

diff | patch | tree

2 years ago Stefan Sperling

check the maximum cached delta size against the correct constant

diff | patch | tree

2 years ago Stefan Sperling

convert delta cache to a hash table

This approach uses more memory but is much faster. To offset the additional memory usage somewhat the cache now stores very small deltas only. However, overall memory usage goes up. Hopefully we will find a way to reduce this later. ok op@

diff | patch | tree

2 years ago Omar Polo

set `ret' in a few places where it was forgotten; ok tracey@

diff | patch | tree

2 years ago Omar Polo

don't pass $ret to test_done on failure when it's known to be zero

Otherwise the test directory it's not left in place; ok tracey@

diff | patch | tree

2 years ago Stefan Sperling

properly swap cached struct pack array elements in got_repo_cache_pack()

Avoids clobbering open files for delta base/accumulation, leaking file descriptors, and triggering errors from close(2) during got_repo_close() as we try to close the same file descriptor more than once.

diff | patch | tree

2 years ago Stefan Sperling

move creation of tempfiles outside of lib/diff.c

ok tracey

diff | patch | tree

2 years ago Stefan Sperling

tog: override SIGTERM and SIGINT handlers to avoid ncurses cleanup() handler

ok thomas

diff | patch | tree

2 years ago Stefan Sperling

reduce GOT_PACK_CACHE_SIZE to 32, otherwise it uses too many open files

found by tracey

diff | patch | tree

2 years ago Stefan Sperling

ensure that all open basefd/accumfd get closed in got_repo_close()

found by tracey

diff | patch | tree

2 years ago Stefan Sperling

open temporary files needed for delta application in got_repo_open()

This prepares for callers of got_repo_open() that cannot afford to open files in /tmp, such as gotwebd. In a follow-up change, we could ask such callers to pass in the required amount of open temporary files. One consequence is that got_repo_open() now requires the "cpath" pledge promise. Add the "cpath" promise to affected callers and remove it once the repository has been opened. ok tracey

diff | patch | tree

2 years ago Stefan Sperling

avoid get_delta_chain_max_size() in dump_delta_chain_to_mem()

diff | patch | tree

2 years ago Stefan Sperling

avoid get_delta_chain_max_size() in dump_delta_chain_to_file()

diff | patch | tree

2 years ago Stefan Sperling

fix a bug in findwixt() which caused pack files with missing parent commits

The 'nskip' variable is supposed to reflect commits which are waiting on the queue and have the 'skip' color. Only increment 'nskip' when adding such commits to the queue. Problem observed with got send -T and a tag pointing to a deleted branch. Test to reproduce the bug written by op@.

diff | patch | tree

More ↓