Commit Briefs
use strndup instead of malloc+memcpy
Simplifies the reading of the author/committer string and makes also the code shorter. ok stsp@
don't check datalen when calling recv_imsg_error
recv_imsg_error already checks the size of the message, and it does so more precisely than the removed code. ok stsp@
got patch: use ints for line offsets instead of longs
ints have the advantage that their size is more likely to be the same across the various architecture supported by OpenBSD, thus introducing less possible differences. INT_MAX is still (at least) a few order of magnitudes higher than the patches we dealt with (even abnormal ones.) suggested by stsp@
actually guarding against negative line offsets
previous commit looked at some pretty zeroes returned from calloc instead of the actual numbers received.
got patch: guard against invalid (negative) line offsets
under normal circumstances got-read-patch can't send negative line offsets; that's not an excuse not to guard the main process from those as well. This makes sure we bail out early instead of trying to apply the diff.
Bring back object enumeration inside got-read-pack as a fast path.
The problem that was found in the earlier version has been fixed. ok op@
in tog, rework Ctrl+u/d to scroll by half a page, and drop d/u again
This matches actual behaviour of less(1) for Ctrl+u/d, and leaves d/u free for potential future use. Suggested by naddy. Patch by Mark Jamsek
got log: sync match_commit from tog
So that 'got log -S' can match also the author and committer name, and the commit ID too. ok stsp@
reuse a temporary file across commits during got log -p -S
suggested by + ok op@
add one-line output mode to got log with -s flag
-s for short. Moves log search to -S. Patch by Evan Silberman
revert object enumeration in got-read-pack for now; needs more work
This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@