Commit Briefs
CHANGES for 0.100 (tags/0.100)
reintroduce the 'got init' command as an alternative to 'gotadmin init'
New users trying out Got for the first time have reported trouble with finding a way to create a new repository, based on their assumption that Got works like Git which provides a 'git init' command. It doesn't cost us much effort to keep this command available in both programs to make discovery a bit easier for new users coming from Git.
fix pack file transfers which do not use sidebands
Found while running 'got clone' against a git9 server, after an unrelated issue was reported by Lucas on IRC, thanks! ok op@
plug 'got diff obj1 obj2' line metadata memory leak
Despite API callers not requesting it, we collect line metadata due to NULL pointer checks missing a level of indirection. Reported by Kyle Ackerman. ok op and stsp
plug a leak in a few cmds: forgot to free(cwd) at the end
spotted while investigating for another leak spotted by Kyle Ackerman. ok stsp@ and jamsek
gotwebd: remove previd and prevset query string parameter
They're no longer used.
gotwebd: delete dead code
at this point we can't know if the client has disconnected, we just finished parsing the fcgi parameters and started handling the reply. We'll know whether the client disconnected only later, while trying to send the page content.
gotwebd: use the last matching fastcgi parameter
in case of multiple parameters with the same name, use the last matching one.
got{web,}d: handle multiple -v
only fatal*() and log_warn*() are now logged by default. log_info() is hidden behind a -v and log_debug behind -vv. Makes gotd and gotwebd way less chatty. ok stsp@
gotwebd: use less temp files
Instead of allocating a whole set of temp fd per `listen' directive, just use a global set per "sockets" process. This is fine since gotwebd doesn't keep multiple connections open at the same time, once it enters gotwebd_process_request() it won't exit until all the page has been processed. (this because we don't have async APIs for got operations.) ok stsp@
remove a redundant bounds check which gets elided by clang
found by + ok op@
gotwebd: allow to change the user
ok stsp@
got{,web}d: unify log.c
gotd and gotwebd are using almost the same log.c file, so unify. This only slightly changes gotwebd logs to include the process name, like gotd. ok stsp@
gotwebd: remove unix_socket_name
Now that `listen' is a top-level, `unix_socket_name' is useless. The default socket remains /var/www/run/gotweb.sock, to listen on an alternate socket now `listen on socket "/some/other/sock" can be used. part of a larger diff that's ok stsp@
gotwebd: make `listen' a top-level statement
gotwebd only uses the server name (i.e. the Host HTTP header) to match the server blocks. Since gotwebd by design sits behind an http server which is expected to filter virtual hosts, there's little point in having `listen' per-server. part of a larger diff that's ok stsp@
adjust gotwebd.conf(5) after recent change
it's no longer required for the host:port tuple to be used only by one server.