Commit Briefs

Thomas Adam

let got-read-pack be explicit about whether it could enumerate all objects

This allows the main process to avoid looping over all object IDs again in case the pack file used for enumeration is complete. ok op@



Thomas Adam

remove trailing whitespaces


Thomas Adam

compute object size, not pointer size

in this case they're luckily the same; got_imsg_object_idlist and got_imsg_reused_delta only have one size_t long field. ok stsp@


Thomas Adam

strictier validation for data received from libexec helpers

use correct error code and ok stsp@


Thomas Adam

drop unused variable


Thomas Adam

use strndup instead of malloc+memcpy

Simplifies the reading of the author/committer string and makes also the code shorter. ok stsp@


Thomas Adam

don't check datalen when calling recv_imsg_error

recv_imsg_error already checks the size of the message, and it does so more precisely than the removed code. ok stsp@


Thomas Adam

got patch: use ints for line offsets instead of longs

ints have the advantage that their size is more likely to be the same across the various architecture supported by OpenBSD, thus introducing less possible differences. INT_MAX is still (at least) a few order of magnitudes higher than the patches we dealt with (even abnormal ones.) suggested by stsp@


Thomas Adam

actually guarding against negative line offsets

previous commit looked at some pretty zeroes returned from calloc instead of the actual numbers received.


Thomas Adam

style; set datalen only once


Thomas Adam

got patch: guard against invalid (negative) line offsets

under normal circumstances got-read-patch can't send negative line offsets; that's not an excuse not to guard the main process from those as well. This makes sure we bail out early instead of trying to apply the diff.


Thomas Adam

free patch on error




Thomas Adam

Bring back object enumeration inside got-read-pack as a fast path.

The problem that was found in the earlier version has been fixed. ok op@


Thomas Adam

portable: remove endian.h

This is included portably.




Thomas Adam

adjust expected test output after got log -s changes

ok op@


Thomas Adam

make got log -s show committer date

ok op@


Thomas Adam

make got log -s display local reference names

ok op@


Thomas Adam

in tog, rework Ctrl+u/d to scroll by half a page, and drop d/u again

This matches actual behaviour of less(1) for Ctrl+u/d, and leaves d/u free for potential future use. Suggested by naddy. Patch by Mark Jamsek


Thomas Adam

got log: sync match_commit from tog

So that 'got log -S' can match also the author and committer name, and the commit ID too. ok stsp@