Commit Briefs

Thomas Adam

implement support for commit coloring in got-read-pack for speed

ok op, tracey


Thomas Adam

tog: echo count prefix when entering compound key maps

like less(1), echo the digits as they're typed. suggested by and ok op@ stsp@


Thomas Adam

got patch: handle git-style diffs for the 3-way merge too

tweak and ok stsp@


Thomas Adam

handle blob ids without corresponding blob ids

ok stsp@


Thomas Adam

build with -Wwrite-strings

Throwing this into the mix for a while, we can always get rid of it again if it becomes annoying. No objections from stsp@



Thomas Adam

always show commit or tree IDs in diff header, in order to help 'got patch'

The idea is that got patch can simply look for a line such as: commit - abcde1234567... to find the merge base commit ID to show in diff3 conflict markers. got log -p now displays commit IDs in its diff header, instead ofl tree or blob IDs. ok op@


Thomas Adam

build with -Wmissing-prototypes

ok stsp@


Thomas Adam

portable: move FreeBSD capsicum header

This tidies up an #include required for capsicum on FreeBSD -- as its inclusion on FreeBSD is unconditional, but masking out cap_enter() on non-FreeBSD systems isn't. No functional change -- it's just cosmetic.



Omar Polo

repopulate .gitignore, revert 78c05fa

Probably due to a rebase, 78c05fa ended up truncating most of the portable .gitignore. Reinstate it with some small tweaks and add got-read-patch while here.


Omar Polo

mention the cross-compilation fix


Omar Polo

add -q to all the regress scripts


Omar Polo

use capsicum on FreeBSD

Thanks to the design of Got, the libexec helpers don't need any resource (in fact they run under pledge "stdio recvfd" on OpenBSD) and so using cap_enter(2) on FreeBSD is dead-easy. While the main process can't be sandboxed on FreeBSD (needs to exec the helpers), all the tough work is done by these small libexec helpers which is also the biggest attack surface. tested by naddy, ok thomas


Thomas Adam

portable: set next version


Thomas Adam

portable: CHANGELOG for 0.71 (tags/0.71)

This updates the CHANGELOG for the 0.71 commit.


Thomas Adam

tog: prefix mvmt keymaps with count modifier like vi(1)

Enable compound commands for all movement keymaps (e.g., hjkl, bfdu). The optional prefixed count determines how many times the movement is performed; for example, '123j' (move 123 lines down) or '4f' (scroll 4 pages down). Counts are ignored if preceding non-movement and some singular movement operations (e.g., 't', 'r', 'ret', '/', '$', 'G', 'g'). ok stsp@


Thomas Adam

got patch: use status G for merged files (and document it)

Suggested by stsp@. This makes possible to tell if 'got patch' used a merge-base from the repository for the 3-way merge or did a simple search/replace operation. While here update the tests to look for the 'G' status and the manpage, which was also missing the documentation for the 'C' status in got patch. ok stsp@


Thomas Adam

got patch: ignore blobs not found

since diffs are often enclosed in other formats (e.g. emails) we might parse something and think it's a blob id when it's not. This should already happens, but apply_patch is looking for the wrong error due to a leftover from previous attempts. Reported by stsp@ while here tweak the test_patch_merge_unknown_blob to also try with a dummy commit id, as now got-read-patch requires it in order to consider a blob id. ok stsp@


Thomas Adam

fix `limit' accounting in draw_commit

if the child view is fullscreen we don't need to subtract one, because no vborder is drawn. ok Mark Jamsek


Thomas Adam

tog: make SPACE page down in all views

ok op@, Mark Jamsek


Thomas Adam

fix fullscreen view regression introduced in 0dbbbe90fd

When cycling from a child view in fullscreen, the parent view is opened in a splitscreen with no border instead of fullscreen. Check the view mode when cycling between views and resize parent dimensions accordingly. ok op@


Thomas Adam

alias C-b/C-f to scroll page back/forward with b/f

Suggested by naddy. Remap 'f'ullscreen to 'F', and blame view key maps 'b' and 'B' to 'c' and 'C', respectively, per stsp's and naddy's suggestion. While here, remove trailing whitespace. ok naddy@


Thomas Adam

use the commitid in the patch diff3 conflict header

suggested by and ok stsp@


Thomas Adam

got patch: use diff3 to merge the changes

Parse the "blob -" metadata in diffs produced by 'got diff' and use the original file for patching. Then, use the diff3 with the current version of the file to merge the differences. This solves many failures automagically or at least turns them into a conflict. ok/improvements stsp@