Commit Briefs

Omar Polo

gotwebd: allow to change the user (main)

ok stsp@


Omar Polo

got{,web}d: unify log.c

gotd and gotwebd are using almost the same log.c file, so unify. This only slightly changes gotwebd logs to include the process name, like gotd. ok stsp@


Omar Polo

gotwebd: mention the listening socket path under FILES

ok stsp@


Omar Polo

gotwebd: remove unix_socket_name

Now that `listen' is a top-level, `unix_socket_name' is useless. The default socket remains /var/www/run/gotweb.sock, to listen on an alternate socket now `listen on socket "/some/other/sock" can be used. part of a larger diff that's ok stsp@


Omar Polo

gotwebd: make `listen' a top-level statement

gotwebd only uses the server name (i.e. the Host HTTP header) to match the server blocks. Since gotwebd by design sits behind an http server which is expected to filter virtual hosts, there's little point in having `listen' per-server. part of a larger diff that's ok stsp@


Omar Polo

adjust gotwebd.conf(5) after recent change

it's no longer required for the host:port tuple to be used only by one server.


Omar Polo

gotwebd: simplify handling of unix sockets

- don't assume an implicit "listen on socket" when another listen was specified in a server block - allow servers to share the sockets they're listening on - fix unix_socket_name; now it's actually used - remove `listen on socket off' and `unix_socket off' options that are now no longer useful - unify the internal handling of the sockets, i.e. don't consider unix socket special. ok tracey@


Omar Polo

gotwebd: plug leak in get_addrs() error path

h is free'd by add_addr in case of error, but we still leak the getaddrinfo result. while here make the check strictier: addr_addr() fails with -1.


Omar Polo

got-fetch-http: be pedantic with the error checking

these functions are expected to return -1 on failure, be strict about it.



Omar Polo

bufio: crank BIO_CHUNK up to 64k

forgot it set to a low value when testing the resizing, the left way too low. prodded by stsp. ok stsp




Stefan Sperling

fix wrong errno check in bufio_close_sync()

ok thomas_adam, op@



Christian Weisgerber

regress: make server tests more robust against race hazard

Add a delay after starting the server background process to keep server and client from racing against each other, which would lead to failures when the client ran before the server. ok op


Stefan Sperling

log hostname and port when gotd notification helpers fail to connect

ok op@


Stefan Sperling

gotd regress also needs p5-httpd-daemon



Stefan Sperling

fix Date header generated by got-notify-email

asctime_r() is not a source of valid date strings for email. Borrow code from OpenSMTPD instead for this purpose. Problem reported by naddy, who also found the smtpd code to use.


Stefan Sperling

display abbreviated commit/tag IDs in email notification subject lines

This should make it somewhat easier to keep track of discussion threads when someone replies to a commit notification to discuss the changes.


Stefan Sperling

fix empty notification messages with multiple gotd notification targets

When multiple notification targets are configured only the first target received notification message content. The subsequent targets would read EOF when trying to read the content. Fix this issue and add regression test coverage for it, exercising existing test code with a gotd.conf file which contains two notification targets.



Stefan Sperling

don't leak the existence of gotd repositories to unrelated user accounts

In particular, this prevents anonymous user accounts from discovering the existence of other private repositories served by gotd by correctly guessing the name of a private repository. They still wouldn't have read or write access but in some cases even knowledge about the existence of a particular repository could be cause for concern. ok op@