Commits

Commit:
0ae84acc1f0a0584e4f26ccbe029c895043b3abe
From:
Tracey Emery <tracey@traceyemery.net>
Date:
move got_opentempfd out of got_repo_open. ok stsp@ thanks for all the help massaging this diff
diff | patch | tree
Commit:
06c44edcbf03f02d1d7c07f9360de526dd4203d3
From:
Stefan Sperling <stsp@stsp.name>
Date:
check for errors from fclose() in patch_file()
diff | patch | tree
Commit:
11ce22a1a15a25df1218e6cd79c7c0ff7e951b63
From:
Omar Polo <op@omarpolo.com>
Date:
plug memory and fd leak in got patch
diff | patch | tree
Commit:
33c3719a3133ea565d69348d51b7a65485dbbcee
From:
Stefan Sperling <stsp@stsp.name>
Date:
re-add u/d keybindings as aliases for Ctrl-u/d, matching more(1) and less(1) patch by Mikhail
diff | patch | tree
Commit:
afd3149814241c83780b6f8df65ea0cfa39fbcb8
From:
Stefan Sperling <stsp@stsp.name>
Date:
fix a harmless off-by-one from previous commit
diff | patch | tree
Commit:
a5e587e014cba0e9dc62ab1817983c89851cbe93
From:
Stefan Sperling <stsp@stsp.name>
Date:
fix a bug in got_privsep_send_object_idlist() exposed by recent changes The old code did not work correctly if only a single object Id was to be sent to got-read-pack. Make got-read-pack error out if the list of commits for object enumeration is empty to catch this problem if it occurs again. Found by the send_basic test, which was failing with GOT_TEST_PACK=1 ok tracey
diff | patch | tree
Commit:
db9b9b1c2b70d98419e70b05e7283b2284bedbec
From:
Stefan Sperling <stsp@stsp.name>
Date:
let got-read-pack be explicit about whether it could enumerate all objects This allows the main process to avoid looping over all object IDs again in case the pack file used for enumeration is complete. ok op@
diff | patch | tree
Commit:
ffe3518f1b3ac78ceeac8b605cb0eec2006bae67
From:
Stefan Sperling <stsp@stsp.name>
Date:
fix wrong arguments to calloc(3) in enumeration_request()
diff | patch | tree
Commit:
b4b1b9c0333d1aedca89dd35c4e60ac8684cddac
From:
Omar Polo <op@omarpolo.com>
Date:
remove trailing whitespaces
diff | patch | tree
Commit:
0fca100c2fe2bfd8e88b22246068addedecd343d
From:
Omar Polo <op@omarpolo.com>
Date:
compute object size, not pointer size in this case they're luckily the same; got_imsg_object_idlist and got_imsg_reused_delta only have one size_t long field. ok stsp@
diff | patch | tree
Commit:
c98b0f0b57cce101941efd993eac8b9e3be2a70a
From:
Omar Polo <op@omarpolo.com>
Date:
strictier validation for data received from libexec helpers use correct error code and ok stsp@
diff | patch | tree
Commit:
3e6054c427d642654d5abed63965eead037a7b2f
From:
Omar Polo <op@omarpolo.com>
Date:
drop unused variable
diff | patch | tree
Commit:
bf31a716e240db9b58ddd53f468b3b23e49237c2
From:
Omar Polo <op@omarpolo.com>
Date:
use strndup instead of malloc+memcpy Simplifies the reading of the author/committer string and makes also the code shorter. ok stsp@
diff | patch | tree
Commit:
71fee5a34a12ea7a545b3c4dfbe91023c8f7c69a
From:
Omar Polo <op@omarpolo.com>
Date:
don't check datalen when calling recv_imsg_error recv_imsg_error already checks the size of the message, and it does so more precisely than the removed code. ok stsp@
diff | patch | tree
Commit:
35095610b1bb11a6c722f6d42f6609bd308531a8
From:
Omar Polo <op@omarpolo.com>
Date:
got patch: use ints for line offsets instead of longs ints have the advantage that their size is more likely to be the same across the various architecture supported by OpenBSD, thus introducing less possible differences. INT_MAX is still (at least) a few order of magnitudes higher than the patches we dealt with (even abnormal ones.) suggested by stsp@
diff | patch | tree
Commit:
5b7126c502f8d046d0779dd2cb0558163c383819
From:
Omar Polo <op@omarpolo.com>
Date:
actually guarding against negative line offsets previous commit looked at some pretty zeroes returned from calloc instead of the actual numbers received.
diff | patch | tree
Commit:
2399b53d3a5f7a784efc54b86027b4f50f65ac41
From:
Omar Polo <op@omarpolo.com>
Date:
style; set datalen only once
diff | patch | tree
Commit:
71393b5c7fb0a8cff0c8fd7890c3954e3f3a9599
From:
Omar Polo <op@omarpolo.com>
Date:
got patch: guard against invalid (negative) line offsets under normal circumstances got-read-patch can't send negative line offsets; that's not an excuse not to guard the main process from those as well. This makes sure we bail out early instead of trying to apply the diff.
diff | patch | tree
Commit:
0e07a2a181ad1663e726597758495e6b8010ba97
From:
Omar Polo <op@omarpolo.com>
Date:
free patch on error
diff | patch | tree
Commit:
99b94ad7a7280ebcb23a103b28c81900bbe250ee
From:
Omar Polo <op@omarpolo.com>
Date:
got patch: ensure new and old paths are NUL-terminated
diff | patch | tree
Commit:
eb7b30a1caf056832bec7619ececf88efa18f6bd
From:
Stefan Sperling <stsp@stsp.name>
Date:
fix error handling in find_pack_for_enumeration(); pointed out by op@
diff | patch | tree
Commit:
0ab4c95723904e176687f5edc131bdf422dd261a
From:
Stefan Sperling <stsp@stsp.name>
Date:
Bring back object enumeration inside got-read-pack as a fast path. The problem that was found in the earlier version has been fixed. ok op@
diff | patch | tree
Commit:
85c34e74e98435d0ebb99360b18587411a652741
From:
Stefan Sperling <stsp@stsp.name>
Date:
fix error case handling in print_commit_oneline(); pointed out by op@
diff | patch | tree
Commit:
61dd0f65df684a93379cfa4c195ba43ee493bfc7
From:
Stefan Sperling <stsp@stsp.name>
Date:
remove outdated and overly-specific documentation of got log -s output ok op@
diff | patch | tree
Commit:
783ffc01fc5be0775c44984236ac9f1d1d0ad581
From:
Stefan Sperling <stsp@stsp.name>
Date:
adjust expected test output after got log -s changes ok op@
diff | patch | tree