Commits
- Commit:
0fb910a41f7587983405793e780968c72b3f4197
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make new pkt read timeout apply only to gotsh, not the client-side helpers
- Commit:
6fefa431eee865872ebe9a069e18cba946baf1df
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
use polling read in got_pkt_readn() to avoid endless hangs in gotsh
- Commit:
c811fd62d1fbec7ac5e58e10b242c3d4f8b4cdb4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix an issue where 'git fetch' would error or hang against gotd
If Git has more than 16 have-lines to send it will send a flush-pkt
followed by more have-lines. Due to a misunderstanding on my part,
gotd didn't like this because it assumed that the flush-pkt terminates
the list. Add a test coverage in a new file which we can use to test
Git interop issues.
Fixes a problem seen by Thomas Adam upon git fetch from got.g.o.
- Commit:
6e5370b0f38658d91de41782c4fec170db11606c
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add a basic gotd test which uses git clone instead of got clone
- Commit:
7268d4618603a3243f53ced23fc7ccc40f7d0693
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
gotd_request_timeout() should use log_warnx() since errno is not used here
- Commit:
01fd0993d95a7f79f9931ffaebbda0f08a23ccee
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent spurious failure of gotd test_clone_basic_access_denied
Filter output for a single error message to avoid spurious test
failures which result from output appearing in an unexpected order:
test_clone_basic_access_denied
--- /tmp/gotd-test-clone_basic_access_denied-IkTXPlX5FH/stderr.expected ...
+++ /tmp/gotd-test-clone_basic_access_denied-IkTXPlX5FH/stderr ...
@@ -1,2 +1,2 @@
-got-fetch-pack: test-repo: Permission denied
got: fetch failed
+got-fetch-pack: test-repo: Permission denied
test failed; leaving test data in /tmp/gotd-test-clone_basic_access_denied-IkTXPlX5FH
- Commit:
c025ee6f31e47e1c1d5e835c1f8cf2db3d4ac636
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix wrong function name in errno error message
- Commit:
bcb309261e439efc6ff6b567d9df9f6b837364bf
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
attempt to fix lingering gotd processes from reading clients
When reading clients close the connection early do not ignore
this condition in session_read. The code removed here intended
to handle the case of a writing client uploading a pack file,
and thus does not belong into session_read.c.
I overlooked this when splitting session.c into two files.
This might fix an issue observed on got.g.o where the anonymous
user was no longer connected and left lingering session_read and
repo_read processes hanging around until the request timeout was
reached.
- Commit:
caa6cf11e1afc94b38d5250e9b6fe574a6e5ca80
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
ensure gotd request timeout gets armed even if no request is received
- Commit:
41e288ac19dc1ed47e4e0b2260ebc96a8e0dc2f4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
raise log level of message that is logged when a gotd request times out
- Commit:
841969e1ced43e1e9e2d6c8e3b22541e24337eb9
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got-notify-http: rename auth_user -> authenticated_user
ok stsp@
- Commit:
5a810f318bdf6918a86fe0ce770d2eda026e6932
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
add default case to the switch statement in choose_patch()
Just in case the code futher up gets tweaked again such that the
validity check using strchr() will be skipped in some edge case.
Lucas agrees
- Commit:
c37c2f0a725cab61f43b8fa90096814ca9f24e33
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make got stage -p behave the same way in interactive and -F modes for 'q'
Lucas agrees
- Commit:
c3cc85a3c5ab8491266b207eeb1fb6b6061274ed
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd notifications work when 'git push' is used instead of 'got send'
Git clients disconnect earlier, which resulted in session_write exiting before
notifications were sent. Do not treat early EOF as a fatal error if we are
sending notifications. Add regression test coverage for 'git push'.
Problem found by Thomas Adam.
- Commit:
e6370d593b348b23199788e4b0d5a23f14dde15e
- From:
- Lucas Gabriel Vuotto <lucas@lgv5.net>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
got: refactor choose_patch
Unify the handling of a response file and interactive use, handle EOF,
fix a memleak and make it easier to extend in the future. In particular,
interactive mode now doesn't loop forever on EOF.
Patch by Lucas Gabriel Vuotto.
Joint work with op.
- Commit:
cad8b35d324b72b8fb478e8ab353da1824d82039
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
in gotd.conf(5) use .Sq instead of .Dv when referring to JSON field names
Reads better because .Dv has no discernable effect in terminal or HTML.
discussed with op@
- Commit:
fb755b83b51e79235a2c548dd81d04db933f81e8
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move GOTD_ACCESS_DENIED more bits away from GOTD_ACCESS_GRANTED
A similar change was made to doas(1) recently in response to rowhammer.
- Commit:
3b9204c0847d7876d8a85203b0f35d50b21a682f
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
document common JSON notification object properties separately
Document properties which are always set just once and upfront,
and list the object types and type-specific properties afterwards.
- Commit:
d53cd0a66bac59d54ebcc581984ce4cf7a63b660
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
in gotd.conf, fix markup of the branch-deleted notification field list
This list was using -compact which was inconsistent with the lists for
other notification types.
- Commit:
9d42388a1a146c8563b1eae304f084a5881c09b9
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
require -u option when invoking got-notify-http
The authenticated username is always available so it makes little
sense to treat it as an optional parameter.
Suggested by op@
- Commit:
d36998aec867c8134466eccfe048dc8671eecca5
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
expose authenticated gotd user account in HTTP notifications
ok op@
- Commit:
b2c9f618aa4d760f0edfc7dbf6bcd01ca38aca17
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
regress: use standard shell idiom for default values
- Commit:
2959f41846dadc2d7826083bfc86d41a49b37420
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: add the magic ".git" handling
like gotd, assume an implicit ".git" if the repo doesn't exist.
Merge gotweb_init_repo_dir() and gotweb_load_got_path() since the
former only sets repo_dir->name, and we don't realistically know
the name until we've opened the directory.
While here, unbreak the git worktree handling too.
Realistically, moving forward, we should issue a redirect to the
canonical URL or at least set the correct metadata in the document
to avoid having multiple URLs for the same content.
ok stsp; tiny change to repo_dir->name handling done after the ok.
- Commit:
99ed25deb726bbb5294a88152cb1ab8a2049f537
- From:
- Omar Polo <op@omarpolo.com>
- Date:
regress: allow to customize GOT_TEST_HTTP_PORT
- Commit:
60ac05357c165b2b9aa4836616db21eeaa4211ea
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
redo "got-fetch-http: fix GET request URL", without breaking tests
My previous fix for ~user in SSH URLs broke ~user in HTTP URLs,
as used on sourcehut. Sanitize the amount of leading and embedded
slashes in URLs to make things work in all cases.
The root cause of the test problem with naddy's previous diff was
likely in the http-server script itself, where a request like
GET //repo//info/refs?service=git-upload-pack somehow ended up as
GET $testroot///info/refs. We work around this here by avoiding
the double slashes.