Commits
- Commit:
1f3405c91dec0b4eb48df5156751b5ef6add3f37
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
refactor got log -d and tog diffstat to compute diff once
This eliminates the previous performance cost by making 'got log -d' and tog
diff view compute the diffstat while building the diff in a temp file like we
do with 'got diff -d'. Also, keep the current 'got log -d' UI as per stsp's
suggestion.
ok stsp@
- Commit:
4a1a737306fe863c1d6378370d345fae962a2cad
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
fix diff and log diffstat tests broken in 65dedee0a2cd
I failed to update regress when changing the diffstat summary line in the
previous commit to use a singular noun after 1.
ok op@ and stsp@
- Commit:
c18e88e5d11bc9c1d5016a1eb8911858ad2077de
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
update gotd TODO items
- Commit:
65dedee0a2cddb92e5184e594424e1d42420e8b0
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
don't use plural noun after 1 in diffstat total
Use singular form when appropriate; for example, turn the top into the bottom:
1 file changed, 1 insertions(+), 1 deletions(-)
1 file changed, 1 insertion(+), 1 deletion(-)
ok op@
- Commit:
d38823945b8782a695c7edc575f2e85a16b53d95
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: delete now unused code
gotweb_escape_html and gotweb_link are now completely unused.
ok jamsek
- Commit:
760079985fc2d63ebd4155a76d4f0d20fbc2f4c5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: inline got_output_file_blob into gotweb_process_request
ok jamsek
- Commit:
8319855fa7affdb1199a46d76f87b9fec409eb81
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_blame
ok and tweak from jamsek
- Commit:
13e39a526914745e246b70efd87083d3097a31eb
- From:
- Omar Polo <op@omarpolo.com>
- Date:
zap empty line
- Commit:
69525b4e7234cc5d81905e84a67d9b1768606e34
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_summary
ok jamsek
- Commit:
d60961d296583c78051ab30aeee8171fd9611aac
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: bubble up got_get_repo_tags
This bubbles up the call to got_get_repo_tags from gotweb_render_tags to
its caller, gotweb_process_request and gotweb_render_summary. It helps
simplifying gotweb_render_summary and making it easier to templateify,
but also helps in untangling a bit the code.
At this point gotweb_render_tags becomes just a wrapper to
gotweb_render_tags_tmpl so switch completely to it.
ok jamsek
- Commit:
3ab2c91424750aef75f929402e6a7581a704f36d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: templateify gotweb_render_branches
no functional change intended. Bubble up the allocation of the reflist
from gotweb_render_branches to gotweb_render_summary (its only caller)
and rewrite it as a template.
ok tracey@
- Commit:
5fa52d6cdcc6de872ce3c7f6639cc638fd83eeea
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
got: style(9) and cleanup failure leaks lib/diff.c
Spotted while implementing diffstat plus one introduced with diffstat code.
Don't leak 'change' on got_pathlist_append() error. And don't leak modestr{1,2}
and l{1,2} char pointers in diff_blobs() and got_diff_tree(), respecitvely.
Regarding modestr leaks, rather than free at all error return points, use op's
suggestion to lift modestr vars to function scope.
ok op@
- Commit:
a7331d50e5949de9db777b05789d7180d1082fd4
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
got: set error on asprintf() failure
ok op@
- Commit:
00b3e9ae14f04a45f1ca7445bade6b41a6e8a1c5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
replace malloc+memcpy with strndup. no functional change intended
ok stsp@
- Commit:
bfed0e200a721018cbc04abab4d86e4e700ad741
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
got.1: Add example which lists recently modified branches. I use this a lot.
- Commit:
f7a854cff3b036707a2322ebff8540f29561a8a5
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
use just one pointer variable to keep track of a client's repo process
ok op@
- Commit:
eac23c306591c21ddaa23930159d302f668ae34c
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
update client state tracking in the gotd parent process
The session process takes over the old state definitions under
a new name ("session state"). The parent only needs to keep
track of whether a client has been granted access, so it only
uses two states: NEW, and ACCCESS_GRANTED which is set as soon
as the auth process has granted repository access and before
the session and repo_read/repo_write children are started.
Because 'gotctl info' can no longer observe the session state
remove support code for printing it.
ok op@
- Commit:
e26970ccc755b7327924d761d1772a1bc5a5bf01
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotd: delete trailing blanks spotted while re-reading
- Commit:
6c3d326354af2183c210a5f1422d4c99a606ae66
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: show committer instead of author in BRIEFS
- Commit:
af800df5a11beb2e4b8f519f7b5171a41095afb6
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: use from/via in gotweb_render_commits too
like the previous, show also the committer if different from the author.
- Commit:
49632cd3b1c81b19229e3a4a523e411d29cd8827
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: make commit page more like `got log' / tog
- drop the "diff commit1 commit2" header; it's already showed in the
body of the diff.
- hide the tree id (not that useful to show.)
- show the committer if different from the author.
- use From/Via for Committer/Author.
discussed with jamsek, stsp, tracey
ok jamsek tracey
- Commit:
ee0b2e502f3be1d01835e96bdcd38afed67429f7
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove support for showing client capabilities in 'gotctl info'
The gotd parent process has lost access to client capabilities.
Take the easy way out and remove related code. If needed, client
capabilities can still be found in the debug log with 'gotd -v'.
ok op, jamsek
- Commit:
2e6043e87514d1a49e1c8a037d7c4e20869b07ad
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: fix {first,last}_displayed_line dead store
Both are already assigned just above in open_diff_view()
ok op@
- Commit:
910d235d362fb7951e997ce08e3dfb4b8cb24c5d
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
typo: pass rejectfile--not outfile--to got_ferror()
ok stsp@
- Commit:
38ef2333dd2b85b1e6aed14ef36bca80cb8eb551
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
catch a few missed got_pathlist_append() error checks
ok stsp@