Commits
- Commit:
2497f032fa6bc06264d8990fdd57a9ffbaf1429b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
tog: override SIGTERM and SIGINT handlers to avoid ncurses cleanup() handler
ok thomas
- Commit:
cfcf1cbc17e0ba04db86f31e48233e0ef2e9fd6d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reduce GOT_PACK_CACHE_SIZE to 32, otherwise it uses too many open files
found by tracey
- Commit:
13242195c28da5b721878751b7cb7beb3fa0e264
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
ensure that all open basefd/accumfd get closed in got_repo_close()
found by tracey
- Commit:
571608344a37fb96f46850a1124415ab68b1a431
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
open temporary files needed for delta application in got_repo_open()
This prepares for callers of got_repo_open() that cannot afford to
open files in /tmp, such as gotwebd. In a follow-up change, we could
ask such callers to pass in the required amount of open temporary files.
One consequence is that got_repo_open() now requires the "cpath" pledge
promise. Add the "cpath" promise to affected callers and remove it once
the repository has been opened.
ok tracey
- Commit:
f18c433aae68e5537cf67eae05c0343e970307ad
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid get_delta_chain_max_size() in dump_delta_chain_to_mem()
- Commit:
6395114c60289f3ac0f28c0fc4b5dfcef8690cdf
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid get_delta_chain_max_size() in dump_delta_chain_to_file()
- Commit:
ce2bf7b7c9058374563c6db8608dbab9df2bba7d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix a bug in findwixt() which caused pack files with missing parent commits
The 'nskip' variable is supposed to reflect commits which are waiting on
the queue and have the 'skip' color. Only increment 'nskip' when adding
such commits to the queue.
Problem observed with got send -T and a tag pointing to a deleted branch.
Test to reproduce the bug written by op@.
- Commit:
d6a28ffe187127e3247254d7e242bb52d66eb26b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use random seeds for murmurhash2
change the three hardcoded seeds to fresh ones generated on demand via
arc4random. Suggested/fixed by and ok stsp@
- Commit:
17cfdba68dcb4432269af930abb1f9fb9ee48e97
- From:
- Omar Polo <op@omarpolo.com>
- Date:
include header
- Commit:
411cbec1f714f639184814306c5c88454521e289
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
shrink struct got_pack_meta a bit by removing the have_reused_delta flag
This flag can be expressed as m->reused_delta_offset != 0 because all
deltas in valid pack files will be written at a non-zero offset.
We allocate a huge number of these structs during packing, so every
little bit helps.
- Commit:
adb4bbb29d6a1407355e47e71716ca7f40c6dd67
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reduce the amount of memory used for caching deltas during deltification
With files sorted properly for deltification we produce better deltas
but end up consuming more memory and risk running into OpenBSD ulimits
during packing. To compensate, reduce the threshold for the amount of
delta data we store in memory, spooling more deltas into the cache file.
ok op@
- Commit:
f8174ca59ba426ea9c475fd15d2db770f8595b5e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
store a path hash instead of a verbatim path in pack meta data
This reduces memory use by gotadmin pack. The goal is to sort files
which share a path next to each other for deltification. A hash of
the path is good enough for this purpose and consumes less memory
than a verbatim copy of the path. Git does something similar.
ok op@
- Commit:
3e6ceea0bd8a65737eb2231ce18d0e591dfb92ff
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix paths stored in pack meta data, improving file deltification
The old code was broken and stored an empty path or filenames, instead
of a repository-relative path. Which means we didn't sort files for
deltification as was intended.
Fixing this provides much better deltas in large pack files written by
gotadmin pack -a. In my test case, pack size changed from 2GB to 1.5GB.
ok op@
- Commit:
17259bfa94068499f61aec3129c47ae2671bd531
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug a small memleak on error in got_pack_create()
- Commit:
e1f5d7cf67ae80171a7360796fb87c328f22cff3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid malloc/free for duplicate check in got_pathlists_insert()
ok op@
- Commit:
c9b75c7bd7036a6895bbc3eba2ed0369238ebab4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
revert "Skip poll(2) if an imsgbuf has a non-empty read buffer"
imsg_read() will call recvmsg() on the file descriptor regardless
of the read buffer's state, so we should ensure that data is ready.
The read buffer is used by imsg_get(), not imsg_read().
We already call imsg_get() before imsg_read(), and call the latter
only if imsg_get() returns zero.
- Commit:
2ab714554f1fd2273c9705450cf192dabb4f6b9d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
Skip poll(2) if an imsgbuf has a non-empty read buffer.
- Commit:
1453347d2463ce1b2700dd9fa810f30f2a443e5e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
imsg_add() frees its msg argument on error; avoid double-free in error paths
- Commit:
33fd69c2e53ffe1f0a7e1184293f6918a377376d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
batch up tree entries in imsg instead of sending one imsg per tree entry
This speeds up loading of trees significantly.
ok op@
- Commit:
9985f404ff5dc911b6186e5fa6233fa36848a19a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
parse tree entries into an array instead of a pathlist
Avoids some extra malloc/free in a performance-critical path.
ok op@
- Commit:
3483a4da364d64c5b630cec74a97fab5b5035c65
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent an out-of-bounds access in got_privsep_recv_tree()
- Commit:
baef4d750d80fcf0fddce409470150e73ae120d3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug memory leak in an error path of got_privsep_recv_tree()
- Commit:
13fcf1bf305bb86f5bbe5da661f8811846b79d61
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make got_privsep_recv_tree() reject trees with less than zero entries
- Commit:
7429ae85e5dff2953bced09c774ea43f501e8929
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
rework logic in got_privsep_recv_tree() to avoid an ugly 'goto'
no functional change
- Commit:
4bcdc8959af14bcb2e50c7f303df6c055573bc7a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
refactor got_patch / got_worktree_patch_complete
let got_patch own fileindex_path and call got_worktree_patch_complete
only if got_wokrtree_patch_prepare hasn't failed.
suggested by stsp@