Commits
- Commit:
25054c242b7401a2a20e3c8b87f0a7d61d568909
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
plug memory and fd leak in got patch
- Commit:
23427b14257d8e3f07f57ee08f37763110405c58
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
re-add u/d keybindings as aliases for Ctrl-u/d, matching more(1) and less(1)
patch by Mikhail
- Commit:
8f3ec65d2190a456c91894e98d4d9bab1e33682f
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix a harmless off-by-one from previous commit
- Commit:
ef53e23c28efc2b91e6a2fbbb3a1e914a895745d
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix a bug in got_privsep_send_object_idlist() exposed by recent changes
The old code did not work correctly if only a single object Id was to
be sent to got-read-pack. Make got-read-pack error out if the list
of commits for object enumeration is empty to catch this problem if
it occurs again.
Found by the send_basic test, which was failing with GOT_TEST_PACK=1
ok tracey
- Commit:
e71f1e62ddab990a047fe827d13b25003a9b8014
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
let got-read-pack be explicit about whether it could enumerate all objects
This allows the main process to avoid looping over all object IDs again
in case the pack file used for enumeration is complete.
ok op@
- Commit:
93088ccae4944671d38d0792e22c381cde9cc82f
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix wrong arguments to calloc(3) in enumeration_request()
- Commit:
774020352cebfc173153d3e48123e1ac922229a5
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove trailing whitespaces
- Commit:
623d55de6ed896de2a4767bd1866fa78326e08c4
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
compute object size, not pointer size
in this case they're luckily the same; got_imsg_object_idlist and
got_imsg_reused_delta only have one size_t long field.
ok stsp@
- Commit:
31d32634997bd59472b751d9fea87298edee75be
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
strictier validation for data received from libexec helpers
use correct error code and ok stsp@
- Commit:
12a8238ea919c7aa1d7dc6cf536d44025cf185d0
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
drop unused variable
- Commit:
79b7acf3bcb23d4ff0ad49e09b9fce549fccb4cc
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
use strndup instead of malloc+memcpy
Simplifies the reading of the author/committer string and makes also the
code shorter.
ok stsp@
- Commit:
c24fd27082b2b39806f9b498af8ab24435ba688e
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
don't check datalen when calling recv_imsg_error
recv_imsg_error already checks the size of the message, and it does so
more precisely than the removed code.
ok stsp@
- Commit:
8ebb3daa7771365ed3667ee1d17a090556495847
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got patch: use ints for line offsets instead of longs
ints have the advantage that their size is more likely to be the same
across the various architecture supported by OpenBSD, thus introducing
less possible differences.
INT_MAX is still (at least) a few order of magnitudes higher than the
patches we dealt with (even abnormal ones.)
suggested by stsp@
- Commit:
06227823b7e714dc42c8b3088e152be044e03b46
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
actually guarding against negative line offsets
previous commit looked at some pretty zeroes returned from calloc
instead of the actual numbers received.
- Commit:
047c926f0572281a2cb8f6a7571e204e48eff0d4
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
style; set datalen only once
- Commit:
eb35d814a71cef3007900867c20d881fcd173039
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got patch: guard against invalid (negative) line offsets
under normal circumstances got-read-patch can't send negative line
offsets; that's not an excuse not to guard the main process from those
as well.
This makes sure we bail out early instead of trying to apply the diff.
- Commit:
9880a1ddc7243c136989370185f03cf6bdc29051
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
free patch on error
- Commit:
ca357dd90579bd69da583a03adbb873b320e7c79
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got patch: ensure new and old paths are NUL-terminated
- Commit:
eee80a61bfd69cf6fe6683d587d454fa4aaec936
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix error handling in find_pack_for_enumeration(); pointed out by op@
- Commit:
63915ee56b87d0499239ed129420c15d499e356f
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
Bring back object enumeration inside got-read-pack as a fast path.
The problem that was found in the earlier version has been fixed.
ok op@
- Commit:
146e62ff57a9f4f28255077902f6889e102e0708
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: remove endian.h
This is included portably.
- Commit:
3ff4cd3cb7275ff6501f11112459f19981554d1e
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix error case handling in print_commit_oneline(); pointed out by op@
- Commit:
aba5482ebaaee13ae12a318b6be73e480fc5d557
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove outdated and overly-specific documentation of got log -s output
ok op@
- Commit:
1d56c8ea1e6e9a349a54c7dae99238fc4af94da5
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
adjust expected test output after got log -s changes
ok op@
- Commit:
6a634b40ca714483871c4add8edac988c7fd89fb
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make got log -s show committer date
ok op@