Commits


reduce delta cache size to avoid running out of memory on large pack files As reported by Jerome Kasper, got-index-pack would run out of memory while cloning projects like LLVM or the Linux kernel. The delta cache was pushed to its maximum size limit of ~2GB, which is much higher than the default user data limit on OpenBSD. Set the delta cache size limits to values which should result in the cache limiting itself to 128MB or less.


add dedicated compilation flag for the delta cache, separate from object cache


zero-initialize all of struct got_deflate_buf in got_deflate_init() Fixes a potential bogus free on error. got_deflate_end() relies on zb.flags to be initialized. It will try to free a bogus zb.outbuf pointer if zb.flags happens to set by uninitialized stack memory while we are calling got_deflate_end() in an error path.


zero-initialize all of struct got_inflate_buf in got_inflate_init() Fixes a potential bogus free on error. got_inflate_end() relies on zb.flags to be initialized. It will try to free a bogus zb.outbuf pointer if zb.flags happens to set by uninitialized stack memory while we are calling got_inflate_end() in an error path.


make gotd work as intended on an empty repository; regression test is upcoming


fix sending of capabilities from gotsh(1) in case repository has no refs


fix crash in got-send-pack when server does not announce any capabilities


remove trailing whitespace; patch by Josiah Frentsos


portable: reorder system_extensions Cosmetic change only. No functional changes expected. Via Anna (cybertailor) Vyalkova


portable: add AM_PROG_AR Needed for stringent checks on Gentoo. Bug 879825. Via Anna (cybertailor) Vyalkova.


fix crash in gotd if client gets disconnected on error; reported by Mikhail


portable: set next version


portable: release 0.78


sync files from diff.git 29c010c8648ec861ee463bc8fa8c66a64dd01154 This brings in a build fix for OpenBSD/sparc64.


changelog markup fix


bump version number


CHANGES for 0.78


fix free() of wrong address in gotweb's parse.y Found by sthen via ports-gcc: gotweb/parse.y:504:3: warning: attempt to free a non-heap object 'file'


remove casts which make older gcc versions unhappy ../lib/diffreg.c:44: error: initializer element is not constant ../lib/diffreg.c:51: error: initializer element is not constant ../lib/diffreg.c:59: error: initializer element is not constant ../lib/diffreg.c:66: error: initializer element is not constant reported by Red on Libera IRC, and by sthen@ who pointed out such failures appearing in landry's sparc64 bulk build logs.


fix reference counting of raw objects opened via privsep helpers Such objects were never closed, resulting in memory and file descriptor leaks.


visit gotctl folder during make obj, release, and clean


do not hint at empty temporary diff files in the log message buffer ok op@


ensure that files are in a state where a diff can be created, before diffing ok op@


use a global flag instead of a per-file flag to detect staged changes ok op@


use mkstemps(3) instead of mkstemp(3) for opening named temporary files Allows 'got commit' to use a ".diff" suffix for temporary diff files. ok op@