Commits
- Commit:
3f69050e707b0f3c73aecf3053782433bc7b328b
- From:
- Kyle Ackerman <kackerman0102@gmail.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix memory leak on error in got_privsep_recv_painted_commits()
Diff from Kyle Ackerman, thank you!
I've added a imsg_free() call before the break too.
- Commit:
16753fcd1c448414735e656a5c4a33048d93d029
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove 'bind interface removal' TODO item
- Commit:
d1d263eac7f7f573e50efe916ebdb779ced7f247
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: inline and remove IMSG_SIZE_CHECK()
I always find confusing if IMSG_SIZE_CHECK() takes pointers or not,
and we had at least a few instances of wrong usages, so inline (with
exact size checks) and remove the macro.
ok stsp@
- Commit:
ab5bda7ecb7748b16898b3af71948dc94ce96296
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove the gotwebd repository cache
It only had 4 slots so was never quite useful, and sharing of sock->pack_fds
across cached repositories seems problematic.
with help from + ok op@
- Commit:
aea518b5677939b97a7c9068389ec98a00dc0ffc
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
whitespace fix
- Commit:
f422fd17f5e761577489af8e09480ed6cd2f61bf
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: ignore SIGPIPE in the sockets processes too
- Commit:
25ebe4706865b1d548e3acb329275fd001378a30
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: send a UNIQUE temp fd
main_compose_sockets() has the 'feature' of implicitly dup(2)'ing
the passed file descriptior. But it's not what we need for the
temp fds, since those needs to be unique per-children.
debugged with stsp@
- Commit:
1962c34091c4aed0109904507f57275774661700
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: don't chdir to / before spawning the child processes
allows to run gotwebd from the got checkout again.
- Commit:
aada9b0335c17c413099d33e3bf242a160871115
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: move log_init() even earlier. I can't read...
- Commit:
f1e20d011992c8e84558cc639c80e53420e2054b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: define constant instead of using the magic number 3
suggested by stsp@
- Commit:
3bb657abe5b3a3d888deadbdc094637dd505dce0
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: make main_compose_sockets() close the fd on error
concern raised by stsp@
- Commit:
f85c939fb7758c7cad91e0705b4d932d52597867
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: get rid of proc.[ch]
proc.c really shines when there's a network of different types of
processes, potentially with a various number of instances each,
that needs to exchange messages. Gotwebd instead has a much simpler
design, and using proc.c causes more overhead (/headaches) than it
solves.
So, this attempts to provide the same functionalities but with a
much simpler implementation that fits gotwebd better.
ok stsp@
- Commit:
b38e9a2a1732c7dd3d16d76facf977f5a4c4a454
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: improve gotwebd_assign_querystring()
This prevents the issues that we just hit with forgetting to remove
PREVID: instead of relying on the enum value to yield the size of
a table, use nitems(). Also, quit as soon as the matching key was
found, no need to iterate further.
ok stsp@
- Commit:
14b59d10858a4042d92f9ec960c38c34fd7e39a6
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: add back drop_privs
- Commit:
fec752080379fa1d041ed3937dfd4ce3fee33fbf
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
allow gotd repo read/write processes to max out data-size resource limits
Proccessing large pack files can easily result in out-of-memory errors
if the datasize limit is too conservative.
- Commit:
a69094689a8fae092c9c9a99c1824d2052525f31
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: garbage-collect PREVID, removed long time ago
This leftover kept QSELEM__MAX bigger than the querystring_keys[]
table and causes gotweb_assign_querystring to go out of bounds.
Spotted on alpine (thanks to -portable.)
- Commit:
dc672b1af772a36d56cf3accc39045085a3541a3
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: remove sockaddr-linux code
Now that socket handling is being done in a portable way upstream,
there's no need to carry -portable specific code.
- Commit:
b9c7eb9112c4b59cc88aff7c7eacaff9aaadba9e
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: move log_init() call a bit earlier
Otherwise the log_warnx() call in the -D case logs to syslog.
- Commit:
7d1d4b6ff2bc57110299da7fafbade01160fa0ef
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: clean up sockets_create_socket a bit
Instead of hardcoding the flags, keep ai_{family,socktype,protocol}
from the getaddrinfo() call and apply them here.
ok stsp@
- Commit:
2edd250dd96801661e3eba82e6b3ee229563f38f
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotadmin: get rid of got_sockaddr.[ch] usage
It was added due to gotwebd weird structure sockaddr_storage handling.
Instead, save the size reported by getaddrinfo() and not reach into
the struct sockaddr_storage at all (except for extracting the port
number for diagnostics purposes.)
sockets_conf_new_socket_fcgi() gets an hardcoded ipproto to zero
(which is the only value it can get in practice, and keeps for the
moment the hardcoded SOCK_STREAM. It'll be cleaned in a follow-up.
ok stsp@
- Commit:
ac485591d020cd11cf0c53e192975f115a9dc40a
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: improve error message in get_addrs(); noticed by stsp@
- Commit:
e760210d3c7975ccc06774dc0404a8a4b6e08927
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: make get_addrs() take the service name directly
This changes how we handle the port number: bubbles up the local
portstr added in previous commit and lets getaddrinfo() deals with
port numbers and services name. getservice() can be gc.
While here add the missing free() in parse.y.
ok stsp@
- Commit:
bdab36da5b4b0a591bb89bdc928cbe739ecbe674
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix typo in previous
- Commit:
61bbe97771c2c1f6246fc5cdfa14cf572cbf5630
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: merge host() and get_addrs(); use * instead of "" for any addr
ok plus tweaks stsp@
- Commit:
08f1c78e511357d5bd17bf80440ee6e6c00a5d3f
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: disable listening on interfaces
ok stsp@