Commits


remove unused function got_path_get_absolute(); realpath(3) is usually better


in got_repo_open(), let realpath(3) take care of relative paths


replace dead_view pointer in view_loop() with 'dying' flag in struct tog_view ok naddy


tog's view_set_child() never returned an error; simplify accordingly ok naddy


remove redundant "child_focussed" variable from struct tog_view ok naddy


tog's log view needs to request more commits when the window expands ok stsp


pass only the view state to scroll functions that don't need the full view ok stsp


reverse tree_view_visit_subtree() parameters for consistency ok stsp


trim repo parameter from tree_view_walk_path(), already set by open_tree_view() ok stsp


trim redundant and used parameters from draw_tree_entries() ok stsp


trim redundant parameters from draw_blame() ok stsp


trim redundant parameters from draw_file() ok stsp


trim redundant and unused parameters from draw_commits() and draw_commit() ok stsp


trim redundant and unused parameters from run_blame() ok stsp


trim redundant parameters from log_scroll_* and trigger_log_thread functions Also rename scroll_{up,down} to log_scroll_{up,down}; requested by stsp. ok stsp


trim redundant parameters from {ref,tree}_scroll_{up,down} functions Pass only the view and scroll amount to these functions; remove unused parameters and those that are contained in the view state. ok stsp


fix page-up/down in 'tog ref' view; ok naddy


fix page-down/page-up scrolling in the tog tree view problem reported by, fixed with lots of help from, and ok naddy


tog: make it possible to open a ref view from the tree view


fix a typo that triggered "munmap: Invalid argument" in got blame on FreeBSD ok stsp


replace echo with printf, stop option processing with "--" for portability ok stsp


fix entry selection when moving to the parent in tog's tree view The tree view attempts to keep the scroll position of an already visited parent directory intact. If we start out by viewing a subtree and then move up, the scroll position of the parent isn't actually available since the parent tree was never nagivated by the user. In this case tree_view_walk_path() has to fill in some values. The only parent entry we know about in this case is the one which was traversed to reach the child. The best we can do is to lock the parent's scroll position such that the traversed child entry appears at the top of the list if moving up to the parent's view. If we then navigate down again and return, the parent's scroll position will start to be retained and restored properly. Analysis and draft patch by stsp, initial report and simpler fix by yours truly. ok stsp


use size_t for loop indices to avoid signedness warnings; from emaste@freebsd


let tog's tree and ref commands call their own usage() and not each other's


support opening a tree view from the ref view; requested by naddy