Commits
- Commit:
5a57034b6f08eec784b8fe3c0b0b734eb2d4605a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: free commit_msg0 only at the end of got_get_repo_tags
in case of a failure between when it's allocated and when it's released
it might get leaked otherwise.
ok and semplification stsp@
- Commit:
b163541dd9b5a61e6be0e3956ab1ed2c591aace5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: plug some leaks in got_get_repo_tags
ok stsp@
- Commit:
f49cdcf59198e93c55db09c0382d04e448b5defe
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: free age and reflist in gotweb_render_branches
ok stsp@
- Commit:
d671c3138b0a55e515557fd21584dd92c4b42a14
- From:
- Tom Jones <thj@freebsd.org>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
switch diff output mode from "edscript" to "plain" for diff3
getchange() in diff3.c takes any line that starts with an integer
and treats it as a hunk header. It doesn't actually require ed script
instructions, and traditional ed script diff output would break it.
Thus, changing Got's diff3 to rely on plain diff output mode paves the
way for implementing traditional ed-script style output in diff.git.
Patch by Tom Jones
- Commit:
f068d119e029fc8d71da9ccc8e84f86c271b2d77
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
sync files from diff.git 810479a563ffd6176105f64cb49f9829d45d36df
- Commit:
5d22ea52df30acf1895cb703d770514a2154b5ae
- From:
- Omar Polo <op@omarpolo.com>
- Date:
plug a leak in match_loose_object
in the loop of match_loose_object we allocate a string per directory
entry that in some case it was free(3)'d before `continue' or `goto',
but not always. Instead, use a more common idiom.
ok stsp@
- Commit:
116d19d9395e2c1d7502e32441724cda7b408ad2
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
sync files from diff.git 35eae7fa6b782ae1d000183ef2efc4383dfec4cd
This removes the gcc ternary if extension (includes follow-up diff.git fix
for missing '\' in wrapped macro 7a38b3a33f8b124c9c01da154dfdf711d328b01d)
- Commit:
2db401bd3a14512e3a1f1cbe686fff37b2c56764
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: free scandir(3) result in gotweb_render_index
ok stsp@
- Commit:
f8faf9f103c9a4869c82a3fe55658f0a065fb1c0
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: free qs->headref before overwriting it
- Commit:
6c37ad7bc12ab6573fdad7e54b1ae0a4d74e5dbf
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix leak in gotweb_init_querystring in error path
if strdup fails we fail to free the querystring
Found by clang' scan-build.
- Commit:
8cf2cdaa9e11ecebdd1142af9539c45b2d33556b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: add missing fcgi_printf return check
dead store found by clang' scan-build.
- Commit:
565bce9b0139246a900c5df6253b2c51f9724ea3
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix assets URLs
In 95a4a5a1e8d0952ee0d2523dc31df7170d80e0b3 I forgot to fix the links
for the favicons and the web manifest.
- Commit:
5fba075071d3c6894ede739a7fc9b791a7f392f7
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix regression in gotweb_free_repo_tag(): free(...): modified chunk-pointer
problem introduced in commit 625e5896fc9ecf87ccfc92ad2a65cd3be58f73c0
- Commit:
b8a4401b8e46c0a32b824433c648ea749898616b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
refresh our pack-index path list if the mtime of objects/pack has changed
ok op@
- Commit:
625e5896fc9ecf87ccfc92ad2a65cd3be58f73c0
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: free all allocated fields of repo_tag
got_get_repo_tags needs some tweaking to how tag_commit is allocated
too.
ok stsp@
- Commit:
89ae185cb4dd6d82b92a79daa8ef484b7da78ec3
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix possible leaks when handling errors
all very unlikely.
part of a bigger diff that's ok stsp@
- Commit:
341fa7cacc77a0a56e7e6eebec0b591ea6d8003b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: minor tweaks
drop:
- a tautological s[strlen(s)] == '\0'
- a few duplicates checks
- a lone if (error) when it's always NULL
- an extra NULL check
part of a bigger diff that's ok stsp@
- Commit:
40a95f4f726567f73ee83d4866608f7ea0654eaa
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: plug leak in fcgi_parse_params
fcgi_parse_params parses fastcgi parameters into a list. (This is a
leftover from slowcgi where that list is later used to populate the
environment of the CGI process.) However, this list is never looked at
and its memory never released, so just drop it.
Make the matching on fastcgi parameters name strictier by checking also
that the length is the one we expect; otherwise we might pick up
parameters with the same prefix string (i.e. FOO vs FOO_WITH_SUFFIX)
While here turn some bcopy into memcpy and simplify some if-nesting too.
Fix the reading from an un-initialized pointer that I introduced in a
previous commit.
ok stsp@
- Commit:
af7ccbc139100f0bb94b8d2ef998dedc122a18f5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: garbage collect the now unused GOTWEB_GOT_DIR
- Commit:
0fad85ddfc19bb67910f06ba6088f27573f83fab
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: refactor gotweb_load_got_path
- don't special case ".got": if it's a work-tree gotwebd will just fail
soon enough. Suggested by stsp@
- avoid an strdup.
- drop `opened' to make it easier to follow what's going on.
ok stsp@
- Commit:
b5c757f5f816a8061f4879da9e68a39141148e40
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotwebd cache open repository handles in struct server
ok op@
- Commit:
d52aad142172d4a9c6219ac2f685a90832fa0838
- From:
- Omar Polo <op@omarpolo.com>
- Date:
indent
- Commit:
4010d4df50dda763bb43dc445ca83ab74420f84e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: plug two memory leak and drop unneeded ternary
ok tracey@
- Commit:
794662a4547b17c0243addf37d330d39e0eb5662
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
don't leak memory allocated internally by bloom filters; ok jamsek
- Commit:
4924afe127087d3fd243c0e488cde9769852ba7b
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: remove gcc ternary if extension
ok stsp@