Commits
- Commit:
5ef2cc1cfe9201155a9843d7538a9b6bf3c3b74b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
plug a leak in match_loose_object
in the loop of match_loose_object we allocate a string per directory
entry that in some case it was free(3)'d before `continue' or `goto',
but not always. Instead, use a more common idiom.
ok stsp@
- Commit:
b15f45f4606f3d64aa30dac5a61c622a9b88ce09
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
sync files from diff.git 35eae7fa6b782ae1d000183ef2efc4383dfec4cd
This removes the gcc ternary if extension (includes follow-up diff.git fix
for missing '\' in wrapped macro 7a38b3a33f8b124c9c01da154dfdf711d328b01d)
- Commit:
f530ab0e9647e91457d9f44afe8be17788bf1e8a
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: free scandir(3) result in gotweb_render_index
ok stsp@
- Commit:
b07649844986a31ed1720dab9b3717b7fe315b9f
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: free qs->headref before overwriting it
- Commit:
8463025419989fa48e0b637d82db3c9c11119aaf
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix leak in gotweb_init_querystring in error path
if strdup fails we fail to free the querystring
Found by clang' scan-build.
- Commit:
1510f72d86432ddfe0f08cc35fe89497c82bf7f1
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: add missing fcgi_printf return check
dead store found by clang' scan-build.
- Commit:
fb3a8240761404943fd35b3d2c3311e68c0683e4
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix assets URLs
In 95a4a5a1e8d0952ee0d2523dc31df7170d80e0b3 I forgot to fix the links
for the favicons and the web manifest.
- Commit:
c8d0196f09c787edce11ee6b848ecb8ad8afb1b4
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix regression in gotweb_free_repo_tag(): free(...): modified chunk-pointer
problem introduced in commit 625e5896fc9ecf87ccfc92ad2a65cd3be58f73c0
- Commit:
04051e8bf0f434a80f5d786b1c6e9dfc8c99ad45
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
refresh our pack-index path list if the mtime of objects/pack has changed
ok op@
- Commit:
217813df81cbe2ba47d4ed204298a3f204014340
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: free all allocated fields of repo_tag
got_get_repo_tags needs some tweaking to how tag_commit is allocated
too.
ok stsp@
- Commit:
3179741908f46f3c1711b053ad2ab839c746a5bf
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix possible leaks when handling errors
all very unlikely.
part of a bigger diff that's ok stsp@
- Commit:
6b42af1e1d379806c1ef2cccfa084a7b8de605f1
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: minor tweaks
drop:
- a tautological s[strlen(s)] == '\0'
- a few duplicates checks
- a lone if (error) when it's always NULL
- an extra NULL check
part of a bigger diff that's ok stsp@
- Commit:
4630b4b581adda0b6e703db535a33f297f6f3701
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: plug leak in fcgi_parse_params
fcgi_parse_params parses fastcgi parameters into a list. (This is a
leftover from slowcgi where that list is later used to populate the
environment of the CGI process.) However, this list is never looked at
and its memory never released, so just drop it.
Make the matching on fastcgi parameters name strictier by checking also
that the length is the one we expect; otherwise we might pick up
parameters with the same prefix string (i.e. FOO vs FOO_WITH_SUFFIX)
While here turn some bcopy into memcpy and simplify some if-nesting too.
Fix the reading from an un-initialized pointer that I introduced in a
previous commit.
ok stsp@
- Commit:
cee9c573f85a1d71c5836345f0c6eebd7ec2927c
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: garbage collect the now unused GOTWEB_GOT_DIR
- Commit:
c2d3d9a00d9696fa5c68d89ee304f038347d830d
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: refactor gotweb_load_got_path
- don't special case ".got": if it's a work-tree gotwebd will just fail
soon enough. Suggested by stsp@
- avoid an strdup.
- drop `opened' to make it easier to follow what's going on.
ok stsp@
- Commit:
55e6cffd2185ebe82b0abfbdcd92c49778cc928d
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make gotwebd cache open repository handles in struct server
ok op@
- Commit:
718f152479de25de4fbdba147d6fb558e9ca9abe
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
indent
- Commit:
2ad628aa08a0a0084b17fe859200e9401e16379d
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: plug two memory leak and drop unneeded ternary
ok tracey@
- Commit:
c4f29b530a853e6019873550831d52f83a51ecc5
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
don't leak memory allocated internally by bloom filters; ok jamsek
- Commit:
d3f8b1f9b4928339a8421ee84b92b407104086d5
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: remove gcc ternary if extension
ok stsp@
- Commit:
85debd54dc0b01b5608a23c42ce5a98f4c8b2507
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
add a gotwebd todo item
- Commit:
9ee610b2f731caea931101aeca9c86352c592306
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove gotwebd TODO items that are done
- Commit:
209237582eb05869480acc03ce30075a40c8f686
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: drop the x bit from assets in-tree and also when installing
ok stsp@
- Commit:
3870c09167f058aec6fa7194ffdf8fef04017bc1
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
wrap overlong line in diff.sh
- Commit:
ce97161807f15dfd5e47a3a7bd6d84e0e542c56e
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix NULL deref in the object cache debug code; ok stsp@
it's not in code compiled by default as it's under GOT_OBJ_CACHE_DEBUG.